[KJ] [PATCH 7/40] fs/nfs4callback: replace schedule_timeout() with ssleep()

[KJ] [PATCH 7/40] fs/nfs4callback: replace schedule_timeout() with ssleep()

[Nishanth Aravamudan]

[-- Attachment #1: Type: text/plain, Size: 889 bytes --]

Hi,

Please consider applying.

Description: Use ssleep() instead of schedule_timeout() to guarantee the task
delays as expected.

Signed-off-by: Nishanth Aravamudan <nacc@us.ibm.com>

--- 2.6.11-rc1-kj-v/fs/nfsd/nfs4callback.c	2005-01-15 16:55:41.000000000 -0800
+++ 2.6.11-rc1-kj/fs/nfsd/nfs4callback.c	2005-01-18 11:03:27.000000000 -0800
@@ -38,6 +38,7 @@
 #include <linux/list.h>
 #include <linux/inet.h>
 #include <linux/errno.h>
+#include <linux/delay.h>
 #include <linux/sunrpc/xdr.h>
 #include <linux/sunrpc/svc.h>
 #include <linux/sunrpc/clnt.h>
@@ -531,8 +532,7 @@ out:
 retry:
 	atomic_inc(&dp->dl_recall_cnt);
 	/* sleep 2 seconds before retrying recall */
-	set_current_state(TASK_UNINTERRUPTIBLE);
-	schedule_timeout(2*HZ);
+	ssleep(2);
 	status = nfsd4_cb_recall(dp);
 	dprintk("NFSD: nfs4_cb_recall_done: retry status: %d  dp %p dl_flock %p\n",status,dp, dp->dl_flock);
 }

[-- Attachment #2: Type: text/plain, Size: 167 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors

[KJ] Re: [NFS] [PATCH 7/40] fs/nfs4callback: replace schedule_timeout() with ssleep()

[J. Bruce Fields]

[-- Attachment #1: Type: text/plain, Size: 303 bytes --]

On Thu, Jan 20, 2005 at 11:03:52AM -0800, Nishanth Aravamudan wrote:
> Please consider applying.
> 
> Description: Use ssleep() instead of schedule_timeout() to guarantee the task
> delays as expected.

Thanks, but a different fix for this has been submitted.  (Our sleeping
at all there is a bug.)--b.

[-- Attachment #2: Type: text/plain, Size: 167 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors