* [PATCH] fix rpc.gssd -d
@ 2007-01-04 19:46 Steinar H. Gunderson
2007-01-04 20:54 ` Kevin Coffman
0 siblings, 1 reply; 6+ messages in thread
From: Steinar H. Gunderson @ 2007-01-04 19:46 UTC (permalink / raw)
To: nfs
Fix an off-by-one in the handling of the -d option to rpc.gssd; this makes
the option usable again (it would complain that the string was too long).
This patch is originally by Liam Bedford, and extracted from
https://bugs.launchpad.net/ubuntu/+source/nfs-utils/+bug/76409
--- nfs-utils-1.0.10.orig/utils/gssd/gssd.c
+++ nfs-utils-1.0.10/utils/gssd/gssd.c
@@ -118,7 +118,7 @@ main(int argc, char *argv[])
break;
case 'd':
strncpy(ccachedir, optarg, sizeof(ccachedir));
- if (ccachedir[sizeof(ccachedir-1)] != '\0')
+ if (ccachedir[sizeof(ccachedir)-1] != '\0')
errx(1, "ccachedir path name too long");
break;
default:
/* Steinar */
--
Homepage: http://www.sesse.net/
-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys - and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
NFS maillist - NFS@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] fix rpc.gssd -d
2007-01-04 19:46 [PATCH] fix rpc.gssd -d Steinar H. Gunderson
@ 2007-01-04 20:54 ` Kevin Coffman
2007-01-04 23:51 ` Steinar H. Gunderson
2007-02-04 22:53 ` Neil Brown
0 siblings, 2 replies; 6+ messages in thread
From: Kevin Coffman @ 2007-01-04 20:54 UTC (permalink / raw)
To: Steinar H. Gunderson; +Cc: nfs
Thanks Steinar. I'll get to this and the AM_MAINTAINER_MODE patch
soon and resend them to Neil. (Your other recent patches are out of
my arena.)
K.C.
On 1/4/07, Steinar H. Gunderson <sgunderson@bigfoot.com> wrote:
> Fix an off-by-one in the handling of the -d option to rpc.gssd; this makes
> the option usable again (it would complain that the string was too long).
> This patch is originally by Liam Bedford, and extracted from
>
> https://bugs.launchpad.net/ubuntu/+source/nfs-utils/+bug/76409
>
> --- nfs-utils-1.0.10.orig/utils/gssd/gssd.c
> +++ nfs-utils-1.0.10/utils/gssd/gssd.c
> @@ -118,7 +118,7 @@ main(int argc, char *argv[])
> break;
> case 'd':
> strncpy(ccachedir, optarg, sizeof(ccachedir));
> - if (ccachedir[sizeof(ccachedir-1)] != '\0')
> + if (ccachedir[sizeof(ccachedir)-1] != '\0')
> errx(1, "ccachedir path name too long");
> break;
> default:
>
> /* Steinar */
> --
> Homepage: http://www.sesse.net/
>
> -------------------------------------------------------------------------
> Take Surveys. Earn Cash. Influence the Future of IT
> Join SourceForge.net's Techsay panel and you'll get the chance to share your
> opinions on IT & business topics through brief surveys - and earn cash
> http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
> _______________________________________________
> NFS maillist - NFS@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/nfs
>
>
-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys - and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
NFS maillist - NFS@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] fix rpc.gssd -d
2007-01-04 20:54 ` Kevin Coffman
@ 2007-01-04 23:51 ` Steinar H. Gunderson
2007-02-04 22:51 ` Neil Brown
2007-02-04 22:53 ` Neil Brown
1 sibling, 1 reply; 6+ messages in thread
From: Steinar H. Gunderson @ 2007-01-04 23:51 UTC (permalink / raw)
To: Kevin Coffman; +Cc: nfs
On Thu, Jan 04, 2007 at 03:54:05PM -0500, Kevin Coffman wrote:
> Thanks Steinar. I'll get to this and the AM_MAINTAINER_MODE patch
> soon and resend them to Neil. (Your other recent patches are out of
> my arena.)
Thanks.
By the way, I checked out the git repository (finding out the URL was
non-trivial, though!) and discovered that the bzero patch was not applied (I
believe it was sent in quite a while ago). Neil, did you forget, is it in
a queue somewhere, or did I just check out the wrong one? (I used
git://git.linux-nfs.org/pub/linux/nfs-utils/.)
/* Steinar */
--
Homepage: http://www.sesse.net/
-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys - and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
NFS maillist - NFS@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] fix rpc.gssd -d
2007-01-04 23:51 ` Steinar H. Gunderson
@ 2007-02-04 22:51 ` Neil Brown
2007-02-04 23:09 ` Neil Brown
0 siblings, 1 reply; 6+ messages in thread
From: Neil Brown @ 2007-02-04 22:51 UTC (permalink / raw)
To: Steinar H. Gunderson; +Cc: nfs, Kevin Coffman
On Friday January 5, sgunderson@bigfoot.com wrote:
> On Thu, Jan 04, 2007 at 03:54:05PM -0500, Kevin Coffman wrote:
> > Thanks Steinar. I'll get to this and the AM_MAINTAINER_MODE patch
> > soon and resend them to Neil. (Your other recent patches are out of
> > my arena.)
>
> Thanks.
>
> By the way, I checked out the git repository (finding out the URL was
> non-trivial, though!) and discovered that the bzero patch was not applied (I
> believe it was sent in quite a while ago). Neil, did you forget, is it in
> a queue somewhere, or did I just check out the wrong one? (I used
> git://git.linux-nfs.org/pub/linux/nfs-utils/.)
git://linux-nfs.org/nfs-utils
should be enough
I don't remember a bzero patch. Is it just replacing the bzero in
support/nfs/svc_socket.c with a memset ??
NeilBrown
-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier.
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________
NFS maillist - NFS@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] fix rpc.gssd -d
2007-02-04 22:51 ` Neil Brown
@ 2007-02-04 23:09 ` Neil Brown
0 siblings, 0 replies; 6+ messages in thread
From: Neil Brown @ 2007-02-04 23:09 UTC (permalink / raw)
To: Steinar H. Gunderson; +Cc: nfs, Kevin Coffman
On Monday February 5, neilb@suse.de wrote:
> On Friday January 5, sgunderson@bigfoot.com wrote:
> > On Thu, Jan 04, 2007 at 03:54:05PM -0500, Kevin Coffman wrote:
> > > Thanks Steinar. I'll get to this and the AM_MAINTAINER_MODE patch
> > > soon and resend them to Neil. (Your other recent patches are out of
> > > my arena.)
> >
> > Thanks.
> >
> > By the way, I checked out the git repository (finding out the URL was
> > non-trivial, though!) and discovered that the bzero patch was not applied (I
> > believe it was sent in quite a while ago). Neil, did you forget, is it in
> > a queue somewhere, or did I just check out the wrong one? (I used
> > git://git.linux-nfs.org/pub/linux/nfs-utils/.)
>
> git://linux-nfs.org/nfs-utils
> should be enough
>
> I don't remember a bzero patch. Is it just replacing the bzero in
> support/nfs/svc_socket.c with a memset ??
It's OK, I found the patch in my mail and have applied it, thanks.
NeilBrown
-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier.
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________
NFS maillist - NFS@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] fix rpc.gssd -d
2007-01-04 20:54 ` Kevin Coffman
2007-01-04 23:51 ` Steinar H. Gunderson
@ 2007-02-04 22:53 ` Neil Brown
1 sibling, 0 replies; 6+ messages in thread
From: Neil Brown @ 2007-02-04 22:53 UTC (permalink / raw)
To: Kevin Coffman; +Cc: Steinar H. Gunderson, nfs
On Thursday January 4, kwc@citi.umich.edu wrote:
> Thanks Steinar. I'll get to this and the AM_MAINTAINER_MODE patch
> soon and resend them to Neil. (Your other recent patches are out of
> my arena.)
I've applied this patch as it is trivially correct.
Thanks.
NeilBrown
>
> K.C.
>
> On 1/4/07, Steinar H. Gunderson <sgunderson@bigfoot.com> wrote:
> > Fix an off-by-one in the handling of the -d option to rpc.gssd; this makes
> > the option usable again (it would complain that the string was too long).
> > This patch is originally by Liam Bedford, and extracted from
> >
> > https://bugs.launchpad.net/ubuntu/+source/nfs-utils/+bug/76409
> >
> > --- nfs-utils-1.0.10.orig/utils/gssd/gssd.c
> > +++ nfs-utils-1.0.10/utils/gssd/gssd.c
> > @@ -118,7 +118,7 @@ main(int argc, char *argv[])
> > break;
> > case 'd':
> > strncpy(ccachedir, optarg, sizeof(ccachedir));
> > - if (ccachedir[sizeof(ccachedir-1)] != '\0')
> > + if (ccachedir[sizeof(ccachedir)-1] != '\0')
> > errx(1, "ccachedir path name too long");
> > break;
> > default:
> >
> > /* Steinar */
> > --
> > Homepage: http://www.sesse.net/
> >
> > -------------------------------------------------------------------------
> > Take Surveys. Earn Cash. Influence the Future of IT
> > Join SourceForge.net's Techsay panel and you'll get the chance to share your
> > opinions on IT & business topics through brief surveys - and earn cash
> > http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
> > _______________________________________________
> > NFS maillist - NFS@lists.sourceforge.net
> > https://lists.sourceforge.net/lists/listinfo/nfs
> >
> >
>
> -------------------------------------------------------------------------
> Take Surveys. Earn Cash. Influence the Future of IT
> Join SourceForge.net's Techsay panel and you'll get the chance to share your
> opinions on IT & business topics through brief surveys - and earn cash
> http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
> _______________________________________________
> NFS maillist - NFS@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/nfs
-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier.
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________
NFS maillist - NFS@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2007-02-04 23:09 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-01-04 19:46 [PATCH] fix rpc.gssd -d Steinar H. Gunderson
2007-01-04 20:54 ` Kevin Coffman
2007-01-04 23:51 ` Steinar H. Gunderson
2007-02-04 22:51 ` Neil Brown
2007-02-04 23:09 ` Neil Brown
2007-02-04 22:53 ` Neil Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox