Linux NFS development
 help / color / mirror / Atom feed
From: Greg Banks <gnb@sgi.com>
To: Tom Tucker <tom@opengridcomputing.com>
Cc: Linux NFS Mailing List <nfs@lists.sourceforge.net>,
	"Talpey,  Thomas" <Thomas.Talpey@netapp.com>,
	Peter Leckie <pleckie@melbourne.sgi.com>,
	Greg Banks <gnb@sgi.com>
Subject: Re: [RFC,PATCH 3/14] knfsd: prepare reply per transport
Date: Thu, 17 May 2007 17:53:42 +1000	[thread overview]
Message-ID: <20070517075342.GG27247@sgi.com> (raw)
In-Reply-To: <C270E33B.3042D%tom@opengridcomputing.com>

On Wed, May 16, 2007 at 04:35:07PM -0500, Tom Tucker wrote:
> 
> Greg:
> 
> I like this patch organization. I'll replicate this in the integrated
> tree... 

Great.

> > + /* Will be turned off only in gss privacy case: */
> > + rqstp->rq_sendfile_ok = 1;
> 
> I think this belongs in the svc_process logic. It doesn't have anything to
> do with the buffer, but rather whether or not GSS is turned on.

Fixed.

I'll push a revised patchset including feedback from yourself
and Bruce, to you only, in a few minutes.

Greg.
-- 
Greg Banks, R&D Software Engineer, SGI Australian Software Group.
Apparently, I'm Bedevere.  Which MPHG character are you?
I don't speak for SGI.

-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/
_______________________________________________
NFS maillist  -  NFS@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs

  reply	other threads:[~2007-05-17  7:53 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-05-16 19:20 [RFC,PATCH 3/14] knfsd: prepare reply per transport Greg Banks
2007-05-16 20:53 ` J. Bruce Fields
2007-05-17  7:01   ` Greg Banks
2007-05-16 21:35 ` Tom Tucker
2007-05-17  7:53   ` Greg Banks [this message]
2007-05-17  9:16     ` Iyer, Rahul
2007-05-17 15:26       ` Tom Tucker
2007-05-18  3:16       ` Greg Banks
2007-05-18  4:01         ` J. Bruce Fields
2007-05-18  4:08           ` J. Bruce Fields
2007-05-18 14:42         ` Trond Myklebust
2007-05-17 10:48 ` Neil Brown
2007-05-18  6:00   ` Greg Banks

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070517075342.GG27247@sgi.com \
    --to=gnb@sgi.com \
    --cc=Thomas.Talpey@netapp.com \
    --cc=nfs@lists.sourceforge.net \
    --cc=pleckie@melbourne.sgi.com \
    --cc=tom@opengridcomputing.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox