From: Greg Banks <gnb@sgi.com>
To: Neil Brown <neilb@suse.de>
Cc: Thomas Talpey <Thomas.Talpey@netapp.com>,
Linux NFS Mailing List <nfs@lists.sourceforge.net>,
Peter Leckie <pleckie@melbourne.sgi.com>
Subject: Re: [RFC,PATCH 3/14] knfsd: prepare reply per transport
Date: Fri, 18 May 2007 16:00:57 +1000 [thread overview]
Message-ID: <20070518060057.GF5104@sgi.com> (raw)
In-Reply-To: <17996.13075.692664.968549@notabene.brown>
On Thu, May 17, 2007 at 08:48:51PM +1000, Neil Brown wrote:
> On Thursday May 17, gnb@sgi.com wrote:
> >
> > Move the code at the beginning of svc_process() that sets up
> > page buffers for the reply, into a new sko_prepape_reply
> > method in svc_sock_ops.
> >
>
> > +static int
> > +svc_tcp_prepare_reply(struct svc_rqst *rqstp)
> > +{
> > + struct kvec *resv = &rqstp->rq_res.head[0];
> > +
> > + svc_tcpip_prepare_reply(rqstp);
> > +
> > + /* tcp needs a space for the record length... */
> ^^
>
> I appreciate that you are copying a comment verbatim, but can we drop
> the 'a'?
>
Fixed. It now reads
+ /* tcp needs room for the record length... */
Greg.
--
Greg Banks, R&D Software Engineer, SGI Australian Software Group.
Apparently, I'm Bedevere. Which MPHG character are you?
I don't speak for SGI.
-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/
_______________________________________________
NFS maillist - NFS@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs
prev parent reply other threads:[~2007-05-18 6:01 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-16 19:20 [RFC,PATCH 3/14] knfsd: prepare reply per transport Greg Banks
2007-05-16 20:53 ` J. Bruce Fields
2007-05-17 7:01 ` Greg Banks
2007-05-16 21:35 ` Tom Tucker
2007-05-17 7:53 ` Greg Banks
2007-05-17 9:16 ` Iyer, Rahul
2007-05-17 15:26 ` Tom Tucker
2007-05-18 3:16 ` Greg Banks
2007-05-18 4:01 ` J. Bruce Fields
2007-05-18 4:08 ` J. Bruce Fields
2007-05-18 14:42 ` Trond Myklebust
2007-05-17 10:48 ` Neil Brown
2007-05-18 6:00 ` Greg Banks [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070518060057.GF5104@sgi.com \
--to=gnb@sgi.com \
--cc=Thomas.Talpey@netapp.com \
--cc=neilb@suse.de \
--cc=nfs@lists.sourceforge.net \
--cc=pleckie@melbourne.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox