Re: [RFC, PATCH 13/35] svc: Change services to use new svc_create_xprt service

["J. Bruce Fields" <bfields@fieldses.org>]

On Tue, Oct 09, 2007 at 01:32:18PM -0500, Tom Tucker wrote:
> On Tue, 2007-10-09 at 13:09 -0400, J. Bruce Fields wrote:
> > On Mon, Oct 01, 2007 at 02:27:59PM -0500, Tom Tucker wrote:
> > > diff --git a/fs/nfs/callback.c b/fs/nfs/callback.c
> > > index a796be5..e27ca14 100644
> > > --- a/fs/nfs/callback.c
> > > +++ b/fs/nfs/callback.c
> > > @@ -123,8 +123,8 @@ int nfs_callback_up(void)
> > >  	if (!serv)
> > >  		goto out_err;
> > >  
> > > -	ret = svc_makesock(serv, IPPROTO_TCP, nfs_callback_set_tcpport,
> > > -							SVC_SOCK_ANONYMOUS);
> > > +	ret = svc_create_xprt(serv, "tcp", nfs_callback_set_tcpport,
> > > +			      SVC_SOCK_ANONYMOUS);
> > >  	if (ret <= 0)
> > >  		goto out_destroy;
> > >  	nfs_callback_tcpport = ret;
> > 
> > Looks like svc_makesock returned a port number, where svc_create_xprt
> > returns a 0 or -ERRNO.  This is breaking nfsv4 callbacks.
> > 
> 
> Bruce:
> 
> Yikes! I missed that. My inclination is to have this port number pulled
> from xpt_local in the svc_xprt structure. What do you think?

Minor nit: the printk() at the end of fs/lockd/svc.c:make_socks() still
refers to "makesock".  Maybe something like "failed to create sockets"
would be more informative anyway.

--b.

-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >> http://get.splunk.com/
_______________________________________________
NFS maillist  -  NFS@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs