Re: [PATCH] nfsd: select CONFIG_PROC_FS in nfsv4 and gss server cases

["J. Bruce Fields" <bfields@fieldses.org>]

On Thu, Nov 15, 2007 at 05:25:52PM -0500, Trond Myklebust wrote:
> 
> On Thu, 2007-11-15 at 17:20 -0500, J. Bruce Fields wrote:
> > On Thu, Nov 15, 2007 at 05:06:36PM -0500, Trond Myklebust wrote:
> > > 
> > > On Thu, 2007-11-15 at 16:57 -0500, J. Bruce Fields wrote:
> > > > The server depends on upcalls under /proc to support nfsv4 and gss.
> > > > 
> > > > Signed-off-by: J. Bruce Fields <bfields@citi.umich.edu>
> > > > ---
> > > >  fs/Kconfig |    2 ++
> > > >  1 files changed, 2 insertions(+), 0 deletions(-)
> > > > 
> > > > diff --git a/fs/Kconfig b/fs/Kconfig
> > > > index 429a002..340b233 100644
> > > > --- a/fs/Kconfig
> > > > +++ b/fs/Kconfig
> > > > @@ -1670,6 +1670,8 @@ config NFSD
> > > >  	select CRYPTO_MD5 if NFSD_V4
> > > >  	select CRYPTO if NFSD_V4
> > > >  	select FS_POSIX_ACL if NFSD_V4
> > > > +	select PROC_FS if NFSD_V4
> > > > +	select PROC_FS if SUNRPC_GSS
> > > >  	help
> > > >  	  If you want your Linux box to act as an NFS *server*, so that other
> > > >  	  computers on your local network which support NFS can access certain
> > > 
> > > What if you just want it to act as a client? No need for PROC_FS then...
> > 
> > We're inside the config NFSD clause, so if you really want *just* a
> > client, then this doesn't change anything.
> 
> Fair enough. I missed that.
> 
> > So the problematic case would be if you want it to be both client and
> > server, and want to use GSS on the client, but don't want to use GSS on
> > the server, and don't want to compile in proc.
> > 
> > Is that an important case?
> > 
> > If so, OK, we can remove the "select PROC_FS if SUNRPC_GSS".  But it
> > might help to at least keep some documentation here though so people
> > know they need proc if they expect GSS to work on the server.
> > 
> > I suppose we could just add another "server-side gss support" config
> > entry whose only reason for existance is to turn on PROC_FS.
> 
> No need.

OK, thanks for clarifying.--b.

-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2005.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________
NFS maillist  -  NFS@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs