From: "J. Bruce Fields" <bfields@fieldses.org>
To: Peter Staubach <staubach@redhat.com>
Cc: Neil Brown <neilb@suse.de>,
linux-nfs@vger.kernel.org, nfs@lists.sourceforge.net
Subject: Re: [PATCH] nfsd: fail module init on reply cache init failure
Date: Fri, 16 Nov 2007 11:27:18 -0500 [thread overview]
Message-ID: <20071116162718.GI31958@fieldses.org> (raw)
In-Reply-To: <473DC3C0.5080302@redhat.com>
On Fri, Nov 16, 2007 at 11:22:24AM -0500, Peter Staubach wrote:
> J. Bruce Fields wrote:
>> On Fri, Nov 16, 2007 at 10:38:47AM -0500, Peter Staubach wrote:
>>
>>> J. Bruce Fields wrote:
>>>
>>>> On Fri, Nov 16, 2007 at 09:29:21AM -0500, Peter Staubach wrote:
>>>>
>>>>> J. Bruce Fields wrote:
>>>>>
>>>>>> + printk(KERN_ERR "nfsd: failed to allocate reply cache\n");
>>>>>>
>>>>> I was thinking that it might be nice to have something which
>>>>> better explains what the ramifications of this failure might
>>>>> be. This explains _precisely_ what happened, but not what
>>>>> will happen in the future.
>>>>>
>>>> The module will fail to load (or, I suppose, the kernel will fail to
>>>> boot?). So the failure will be pretty obvious.
>>>>
>>>>
>>> The module will fail to load, but I suspect that that won't cause
>>> the system to fail to boot.
>>>
>>
>> OK, but I was thinking of the case where nfsd was built in.
>>
>>
>
> Ahh. Sorry, didn't think about that.
>
> This seems a little strong, doesn't it? To cause the system
> to fail to boot?
Yeah, and I was confused: it's init/main.c:do_initcalls() that does
this, and it just keeps going regardless (and doesn't even log the error
unless debugging is turned on). That makes more sense.
--b.
-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2005.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________
NFS maillist - NFS@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs
_______________________________________________
Please note that nfs@lists.sourceforge.net is being discontinued.
Please subscribe to linux-nfs@vger.kernel.org instead.
http://vger.kernel.org/vger-lists.html#linux-nfs
next prev parent reply other threads:[~2007-11-16 16:27 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-15 21:56 8 patches cleaning up nfsd initialization J. Bruce Fields
2007-11-15 21:56 ` [PATCH] knfsd: cleanup nfsd4 properly on module init failure J. Bruce Fields
2007-11-15 21:56 ` [PATCH] nfsd: cleanup nfsd module initialization cleanup J. Bruce Fields
2007-11-15 21:56 ` [PATCH] nfsd: fail module init on reply cache init failure J. Bruce Fields
2007-11-15 21:56 ` [PATCH] knfsd: cache unregistration needn't return error J. Bruce Fields
2007-11-15 21:57 ` [PATCH] nfsd: select CONFIG_PROC_FS in nfsv4 and gss server cases J. Bruce Fields
2007-11-15 21:57 ` [PATCH] nfsd: fail init on /proc/fs/nfs/exports creation failure J. Bruce Fields
2007-11-15 21:57 ` [PATCH] nfsd: move cache proc (un)registration to separate function J. Bruce Fields
2007-11-15 21:57 ` [PATCH] knfsd: allow cache_register to return error on failure J. Bruce Fields
2007-11-15 22:06 ` [PATCH] nfsd: select CONFIG_PROC_FS in nfsv4 and gss server cases Trond Myklebust
2007-11-15 22:20 ` J. Bruce Fields
2007-11-15 22:25 ` Trond Myklebust
2007-11-15 22:26 ` J. Bruce Fields
2007-11-16 14:29 ` [PATCH] nfsd: fail module init on reply cache init failure Peter Staubach
2007-11-16 15:30 ` J. Bruce Fields
2007-11-16 15:38 ` Peter Staubach
2007-11-16 16:01 ` J. Bruce Fields
2007-11-16 16:22 ` Peter Staubach
2007-11-16 16:27 ` J. Bruce Fields [this message]
2007-11-16 0:41 ` 8 patches cleaning up nfsd initialization Neil Brown
2007-11-16 3:19 ` J. Bruce Fields
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071116162718.GI31958@fieldses.org \
--to=bfields@fieldses.org \
--cc=linux-nfs@vger.kernel.org \
--cc=neilb@suse.de \
--cc=nfs@lists.sourceforge.net \
--cc=staubach@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox