Linux NFS development
 help / color / mirror / Atom feed
From: Tom Tucker <tom@opengridcomputing.com>
To: bfields@fieldses.org
Cc: neilb@suse.de, linux-nfs@vger.kernel.org
Subject: [PATCH 21/38] svc: Change svc_sock_received to svc_xprt_received and export it
Date: Tue, 11 Dec 2007 17:32:41 -0600	[thread overview]
Message-ID: <20071211233240.15718.75813.stgit@dell3.ogc.int> (raw)
In-Reply-To: <20071211233150.15718.40579.stgit-gUwIgmpLGaKNDNWfRnPdfg@public.gmane.org>


All fields touched by svc_sock_received are now transport independent.
Change it to use svc_xprt directly. This function is called from
transport dependent code, so export it. 

Signed-off-by: Tom Tucker <tom@opengridcomputing.com>
---

 include/linux/sunrpc/svc_xprt.h |    2 +-
 net/sunrpc/svcsock.c            |   35 +++++++++++++++++------------------
 2 files changed, 18 insertions(+), 19 deletions(-)

diff --git a/include/linux/sunrpc/svc_xprt.h b/include/linux/sunrpc/svc_xprt.h
index d5ef902..c416d05 100644
--- a/include/linux/sunrpc/svc_xprt.h
+++ b/include/linux/sunrpc/svc_xprt.h
@@ -62,8 +62,8 @@ int	svc_unreg_xprt_class(struct svc_xprt_class *);
 void	svc_xprt_init(struct svc_xprt_class *, struct svc_xprt *,
 		      struct svc_serv *);
 int	svc_create_xprt(struct svc_serv *, char *, unsigned short, int);
+void	svc_xprt_received(struct svc_xprt *);
 void	svc_xprt_put(struct svc_xprt *xprt);
-
 static inline void svc_xprt_get(struct svc_xprt *xprt)
 {
 	kref_get(&xprt->xpt_ref);
diff --git a/net/sunrpc/svcsock.c b/net/sunrpc/svcsock.c
index d546709..d8d88c1 100644
--- a/net/sunrpc/svcsock.c
+++ b/net/sunrpc/svcsock.c
@@ -330,14 +330,13 @@ svc_sock_dequeue(struct svc_pool *pool)
  * Note: XPT_DATA only gets cleared when a read-attempt finds
  * no (or insufficient) data.
  */
-static inline void
-svc_sock_received(struct svc_sock *svsk)
+void svc_xprt_received(struct svc_xprt *xprt)
 {
-	svsk->sk_xprt.xpt_pool = NULL;
-	clear_bit(XPT_BUSY, &svsk->sk_xprt.xpt_flags);
-	svc_xprt_enqueue(&svsk->sk_xprt);
+	xprt->xpt_pool = NULL;
+	clear_bit(XPT_BUSY, &xprt->xpt_flags);
+	svc_xprt_enqueue(xprt);
 }
-
+EXPORT_SYMBOL_GPL(svc_xprt_received);
 
 /**
  * svc_reserve - change the space reserved for the reply to a request.
@@ -766,7 +765,7 @@ svc_udp_recvfrom(struct svc_rqst *rqstp)
 				(serv->sv_nrthreads+3) * serv->sv_max_mesg);
 
 	if ((rqstp->rq_deferred = svc_deferred_dequeue(svsk))) {
-		svc_sock_received(svsk);
+		svc_xprt_received(&svsk->sk_xprt);
 		return svc_deferred_recv(rqstp);
 	}
 
@@ -783,7 +782,7 @@ svc_udp_recvfrom(struct svc_rqst *rqstp)
 			dprintk("svc: recvfrom returned error %d\n", -err);
 			set_bit(XPT_DATA, &svsk->sk_xprt.xpt_flags);
 		}
-		svc_sock_received(svsk);
+		svc_xprt_received(&svsk->sk_xprt);
 		return -EAGAIN;
 	}
 	rqstp->rq_addrlen = sizeof(rqstp->rq_addr);
@@ -798,7 +797,7 @@ svc_udp_recvfrom(struct svc_rqst *rqstp)
 	/*
 	 * Maybe more packets - kick another thread ASAP.
 	 */
-	svc_sock_received(svsk);
+	svc_xprt_received(&svsk->sk_xprt);
 
 	len  = skb->len - sizeof(struct udphdr);
 	rqstp->rq_arg.len = len;
@@ -1104,7 +1103,7 @@ static struct svc_xprt *svc_tcp_accept(struct svc_xprt *xprt)
 	}
 	memcpy(&newsvsk->sk_local, sin, slen);
 
-	svc_sock_received(newsvsk);
+	svc_xprt_received(&newsvsk->sk_xprt);
 
 	if (serv->sv_stats)
 		serv->sv_stats->nettcpconn++;
@@ -1134,7 +1133,7 @@ svc_tcp_recvfrom(struct svc_rqst *rqstp)
 		test_bit(XPT_CLOSE, &svsk->sk_xprt.xpt_flags));
 
 	if ((rqstp->rq_deferred = svc_deferred_dequeue(svsk))) {
-		svc_sock_received(svsk);
+		svc_xprt_received(&svsk->sk_xprt);
 		return svc_deferred_recv(rqstp);
 	}
 
@@ -1174,7 +1173,7 @@ svc_tcp_recvfrom(struct svc_rqst *rqstp)
 		if (len < want) {
 			dprintk("svc: short recvfrom while reading record length (%d of %lu)\n",
 				len, want);
-			svc_sock_received(svsk);
+			svc_xprt_received(&svsk->sk_xprt);
 			return -EAGAIN; /* record header not complete */
 		}
 
@@ -1210,7 +1209,7 @@ svc_tcp_recvfrom(struct svc_rqst *rqstp)
 	if (len < svsk->sk_reclen) {
 		dprintk("svc: incomplete TCP record (%d of %d)\n",
 			len, svsk->sk_reclen);
-		svc_sock_received(svsk);
+		svc_xprt_received(&svsk->sk_xprt);
 		return -EAGAIN;	/* record not complete */
 	}
 	len = svsk->sk_reclen;
@@ -1250,7 +1249,7 @@ svc_tcp_recvfrom(struct svc_rqst *rqstp)
 	svsk->sk_reclen = 0;
 	svsk->sk_tcplen = 0;
 
-	svc_sock_received(svsk);
+	svc_xprt_received(&svsk->sk_xprt);
 	if (serv->sv_stats)
 		serv->sv_stats->nettcpcnt++;
 
@@ -1263,7 +1262,7 @@ svc_tcp_recvfrom(struct svc_rqst *rqstp)
  error:
 	if (len == -EAGAIN) {
 		dprintk("RPC: TCP recvfrom got EAGAIN\n");
-		svc_sock_received(svsk);
+		svc_xprt_received(&svsk->sk_xprt);
 	} else {
 		printk(KERN_NOTICE "%s: recvfrom returned errno %d\n",
 		       svsk->sk_xprt.xpt_server->sv_name, -len);
@@ -1595,7 +1594,7 @@ svc_recv(struct svc_rqst *rqstp, long timeout)
 			__module_get(newxpt->xpt_class->xcl_owner);
 			svc_check_conn_limits(svsk->sk_xprt.xpt_server);
 		}
-		svc_sock_received(svsk);
+		svc_xprt_received(&svsk->sk_xprt);
 	} else {
 		dprintk("svc: server %p, pool %u, socket %p, inuse=%d\n",
 			rqstp, pool->sp_id, svsk,
@@ -1814,7 +1813,7 @@ int svc_addsock(struct svc_serv *serv,
 	else {
 		svsk = svc_setup_socket(serv, so, &err, SVC_SOCK_DEFAULTS);
 		if (svsk) {
-			svc_sock_received(svsk);
+			svc_xprt_received(&svsk->sk_xprt);
 			err = 0;
 		}
 	}
@@ -1870,7 +1869,7 @@ static struct svc_xprt *svc_create_socket(struct svc_serv *serv,
 	}
 
 	if ((svsk = svc_setup_socket(serv, sock, &error, flags)) != NULL) {
-		svc_sock_received(svsk);
+		svc_xprt_received(&svsk->sk_xprt);
 		return (struct svc_xprt *)svsk;
 	}
 

  parent reply	other threads:[~2007-12-11 23:32 UTC|newest]

Thread overview: 83+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-12-11 23:31 [PATCH 00/38] svc: SVC Transport Switch Tom Tucker
     [not found] ` <20071211233150.15718.40579.stgit-gUwIgmpLGaKNDNWfRnPdfg@public.gmane.org>
2007-12-11 23:31   ` [PATCH 01/38] svc: Add an svc transport class Tom Tucker
     [not found]     ` <20071211233152.15718.44241.stgit-gUwIgmpLGaKNDNWfRnPdfg@public.gmane.org>
2007-12-13 18:45       ` J. Bruce Fields
2007-12-17  9:40         ` Tom Tucker
2007-12-17 17:45           ` J. Bruce Fields
2007-12-18  0:26             ` Tom Tucker
     [not found]               ` <1197937584.13463.44.camel-SMNkleLxa3ZimH42XvhXlA@public.gmane.org>
2007-12-18 14:54                 ` J. Bruce Fields
2007-12-18 15:00                   ` J. Bruce Fields
2007-12-18 15:04                   ` Tom Tucker
     [not found]                     ` <1197990256.13463.54.camel-SMNkleLxa3ZimH42XvhXlA@public.gmane.org>
2007-12-18 15:01                       ` J. Bruce Fields
2007-12-18 19:30                       ` Tom Tucker
     [not found]                         ` <1198006238.13463.79.camel-SMNkleLxa3ZimH42XvhXlA@public.gmane.org>
2007-12-18 19:28                           ` J. Bruce Fields
2007-12-11 23:31   ` [PATCH 02/38] svc: Make svc_sock the tcp/udp transport Tom Tucker
     [not found]     ` <20071211233156.15718.7813.stgit-gUwIgmpLGaKNDNWfRnPdfg@public.gmane.org>
2007-12-13 19:01       ` J. Bruce Fields
2007-12-17  9:46         ` Tom Tucker
2007-12-11 23:31   ` [PATCH 03/38] svc: Change the svc_sock in the rqstp structure to a transport Tom Tucker
2007-12-11 23:32   ` [PATCH 04/38] svc: Add a max payload value to the transport Tom Tucker
2007-12-11 23:32   ` [PATCH 05/38] svc: Move sk_sendto and sk_recvfrom to svc_xprt_class Tom Tucker
2007-12-11 23:32   ` [PATCH 06/38] svc: Add transport specific xpo_release function Tom Tucker
     [not found]     ` <20071211233206.15718.73282.stgit-gUwIgmpLGaKNDNWfRnPdfg@public.gmane.org>
2007-12-13 19:31       ` J. Bruce Fields
2007-12-17  9:53         ` Tom Tucker
2007-12-11 23:32   ` [PATCH 07/38] svc: Add per-transport delete functions Tom Tucker
2007-12-11 23:32   ` [PATCH 08/38] svc: Add xpo_prep_reply_hdr Tom Tucker
2007-12-11 23:32   ` [PATCH 09/38] svc: Add a transport function that checks for write space Tom Tucker
     [not found]     ` <20071211233212.15718.69282.stgit-gUwIgmpLGaKNDNWfRnPdfg@public.gmane.org>
2007-12-12 18:10       ` Chuck Lever
2007-12-12 20:00         ` Tom Tucker
2007-12-13 21:33         ` J. Bruce Fields
2007-12-13 21:45           ` Chuck Lever
2007-12-13 22:20             ` Tom Tucker
     [not found]               ` <1197584427.6348.10.camel-SMNkleLxa3ZimH42XvhXlA@public.gmane.org>
2007-12-13 22:28                 ` J. Bruce Fields
2007-12-14 13:59                   ` Chuck Lever
2007-12-14 14:27                 ` Chuck Lever
2007-12-11 23:32   ` [PATCH 10/38] svc: Move close processing to a single place Tom Tucker
2007-12-11 23:32   ` [PATCH 11/38] svc: Add xpo_accept transport function Tom Tucker
     [not found]     ` <20071211233217.15718.14380.stgit-gUwIgmpLGaKNDNWfRnPdfg@public.gmane.org>
2007-12-14 19:01       ` J. Bruce Fields
2007-12-14 19:14         ` Tom Tucker
2007-12-17 10:02         ` Tom Tucker
2007-12-14 19:55       ` J. Bruce Fields
2007-12-15  5:22         ` Tom Tucker
2007-12-17 10:49         ` Tom Tucker
2007-12-11 23:32   ` [PATCH 12/38] svc: Add a generic transport svc_create_xprt function Tom Tucker
2007-12-11 23:32   ` [PATCH 13/38] svc: Change services to use new svc_create_xprt service Tom Tucker
2007-12-11 23:32   ` [PATCH 14/38] svc: Change sk_inuse to a kref Tom Tucker
     [not found]     ` <20071211233224.15718.91339.stgit-gUwIgmpLGaKNDNWfRnPdfg@public.gmane.org>
2007-12-14 20:52       ` J. Bruce Fields
2007-12-15 20:28         ` Tom Tucker
2007-12-11 23:32   ` [PATCH 15/38] svc: Move sk_flags to the svc_xprt structure Tom Tucker
2007-12-11 23:32   ` [PATCH 16/38] svc: Move sk_server and sk_pool to svc_xprt Tom Tucker
2007-12-11 23:32   ` [PATCH 17/38] svc: Make close transport independent Tom Tucker
2007-12-11 23:32   ` [PATCH 18/38] svc: Move sk_reserved to svc_xprt Tom Tucker
2007-12-11 23:32   ` [PATCH 19/38] svc: Make the enqueue service transport neutral and export it Tom Tucker
2007-12-11 23:32   ` [PATCH 20/38] svc: Make svc_send transport neutral Tom Tucker
2007-12-11 23:32   ` Tom Tucker [this message]
2007-12-11 23:32   ` [PATCH 22/38] svc: Move accept call to svc_xprt_received to common code Tom Tucker
2007-12-11 23:32   ` [PATCH 23/38] svc: Remove sk_lastrecv Tom Tucker
2007-12-11 23:32   ` [PATCH 24/38] svc: Move the authinfo cache to svc_xprt Tom Tucker
2007-12-11 23:32   ` [PATCH 25/38] svc: Make deferral processing xprt independent Tom Tucker
2007-12-11 23:32   ` [PATCH 26/38] svc: Move the sockaddr information to svc_xprt Tom Tucker
2007-12-11 23:32   ` [PATCH 27/38] svc: Make svc_sock_release svc_xprt_release Tom Tucker
2007-12-11 23:32   ` [PATCH 28/38] svc: Make svc_recv transport neutral Tom Tucker
2007-12-11 23:32   ` [PATCH 29/38] svc: Make svc_age_temp_sockets svc_age_temp_transports Tom Tucker
2007-12-11 23:33   ` [PATCH 30/38] svc: Move common create logic to common code Tom Tucker
     [not found]     ` <20071211233300.15718.30136.stgit-gUwIgmpLGaKNDNWfRnPdfg@public.gmane.org>
2007-12-14 23:19       ` J. Bruce Fields
2007-12-15 22:14         ` Tom Tucker
2007-12-17 15:27         ` Tom Tucker
2007-12-11 23:33   ` [PATCH 31/38] svc: Removing remaining references to rq_sock in rqstp Tom Tucker
2007-12-11 23:33   ` [PATCH 32/38] svc: Make svc_check_conn_limits xprt independent Tom Tucker
2007-12-11 23:33   ` [PATCH 33/38] svc: Move the xprt independent code to the svc_xprt.c file Tom Tucker
2007-12-11 23:33   ` [PATCH 34/38] svc: Add transport hdr size for defer/revisit Tom Tucker
     [not found]     ` <20071211233309.15718.84852.stgit-gUwIgmpLGaKNDNWfRnPdfg@public.gmane.org>
2007-12-14 23:37       ` J. Bruce Fields
2007-12-15 18:16         ` Tom Tucker
2007-12-11 23:33   ` [PATCH 35/38] svc: Add /proc/sys/sunrpc/transport files Tom Tucker
2007-12-11 23:33   ` [PATCH 36/38] svc: Add svc API that queries for a transport instance Tom Tucker
2007-12-11 23:33   ` [PATCH 37/38] knfsd: Support adding transports by writing portlist file Tom Tucker
     [not found]     ` <20071211233316.15718.85089.stgit-gUwIgmpLGaKNDNWfRnPdfg@public.gmane.org>
2007-12-14 23:51       ` J. Bruce Fields
2007-12-21 17:52         ` Tom Tucker
     [not found]           ` <1198259550.14237.33.camel-SMNkleLxa3ZimH42XvhXlA@public.gmane.org>
2008-01-03 21:13             ` J. Bruce Fields
2008-01-08 17:45               ` Tom Tucker
2007-12-11 23:33   ` [PATCH 38/38] svc: Add svc_xprt_names service to replace svc_sock_names Tom Tucker
     [not found]     ` <20071211233318.15718.11614.stgit-gUwIgmpLGaKNDNWfRnPdfg@public.gmane.org>
2007-12-15  0:03       ` J. Bruce Fields
2007-12-21 17:51         ` Tom Tucker
     [not found]           ` <1198259507.14237.31.camel-SMNkleLxa3ZimH42XvhXlA@public.gmane.org>
2008-01-03 21:14             ` J. Bruce Fields
2008-01-04  0:47               ` Neil Brown
     [not found]                 ` <18301.33306.486417.193770-wvvUuzkyo1EYVZTmpyfIwg@public.gmane.org>
2008-01-14 13:27                   ` Tom Tucker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20071211233240.15718.75813.stgit@dell3.ogc.int \
    --to=tom@opengridcomputing.com \
    --cc=bfields@fieldses.org \
    --cc=linux-nfs@vger.kernel.org \
    --cc=neilb@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox