Linux NFS development
 help / color / mirror / Atom feed
From: Tom Tucker <tom@opengridcomputing.com>
To: "J. Bruce Fields" <bfields@fieldses.org>
Cc: NeilBrown <neilb@suse.de>, <linux-nfs@vger.kernel.org>
Subject: Re: [PATCH 34/38] svc: Add transport hdr size for defer/revisit
Date: Sat, 15 Dec 2007 12:16:00 -0600	[thread overview]
Message-ID: <C3897600.22993%tom@opengridcomputing.com> (raw)
In-Reply-To: <20071214233717.GM23121@fieldses.org>




On 12/14/07 5:37 PM, "J. Bruce Fields" <bfields@fieldses.org> wrote:

> On Tue, Dec 11, 2007 at 05:33:09PM -0600, Tom Tucker wrote:
>> 
>> Some transports have a header in front of the RPC header. The current
>> defer/revisit processing considers only the iov_len and arg_len to
>> determine how much to back up when saving the original request
>> to revisit. Add a field to the rqstp structure to save the size
>> of the transport header so svc_defer can correctly compute
>> the start of a request.
> 
> I know I asked before, and can't remember what happened: has this been
> tested with krb5p?  (I know nobody cares much whether krb5p/rdma works,
> I just want to make sure krb5p/rdma doesn't oops, and that
> krb5p/{tcp,udp} are unchanged.)

I haven't tested this combination. I definitely don't have a kerberos setup,
but I guess I need to sooner or later...

> 
> I'll try it eventually if you don't....
> 
> --b.



  reply	other threads:[~2007-12-15 18:16 UTC|newest]

Thread overview: 83+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-12-11 23:31 [PATCH 00/38] svc: SVC Transport Switch Tom Tucker
     [not found] ` <20071211233150.15718.40579.stgit-gUwIgmpLGaKNDNWfRnPdfg@public.gmane.org>
2007-12-11 23:31   ` [PATCH 01/38] svc: Add an svc transport class Tom Tucker
     [not found]     ` <20071211233152.15718.44241.stgit-gUwIgmpLGaKNDNWfRnPdfg@public.gmane.org>
2007-12-13 18:45       ` J. Bruce Fields
2007-12-17  9:40         ` Tom Tucker
2007-12-17 17:45           ` J. Bruce Fields
2007-12-18  0:26             ` Tom Tucker
     [not found]               ` <1197937584.13463.44.camel-SMNkleLxa3ZimH42XvhXlA@public.gmane.org>
2007-12-18 14:54                 ` J. Bruce Fields
2007-12-18 15:00                   ` J. Bruce Fields
2007-12-18 15:04                   ` Tom Tucker
     [not found]                     ` <1197990256.13463.54.camel-SMNkleLxa3ZimH42XvhXlA@public.gmane.org>
2007-12-18 15:01                       ` J. Bruce Fields
2007-12-18 19:30                       ` Tom Tucker
     [not found]                         ` <1198006238.13463.79.camel-SMNkleLxa3ZimH42XvhXlA@public.gmane.org>
2007-12-18 19:28                           ` J. Bruce Fields
2007-12-11 23:31   ` [PATCH 02/38] svc: Make svc_sock the tcp/udp transport Tom Tucker
     [not found]     ` <20071211233156.15718.7813.stgit-gUwIgmpLGaKNDNWfRnPdfg@public.gmane.org>
2007-12-13 19:01       ` J. Bruce Fields
2007-12-17  9:46         ` Tom Tucker
2007-12-11 23:31   ` [PATCH 03/38] svc: Change the svc_sock in the rqstp structure to a transport Tom Tucker
2007-12-11 23:32   ` [PATCH 04/38] svc: Add a max payload value to the transport Tom Tucker
2007-12-11 23:32   ` [PATCH 05/38] svc: Move sk_sendto and sk_recvfrom to svc_xprt_class Tom Tucker
2007-12-11 23:32   ` [PATCH 06/38] svc: Add transport specific xpo_release function Tom Tucker
     [not found]     ` <20071211233206.15718.73282.stgit-gUwIgmpLGaKNDNWfRnPdfg@public.gmane.org>
2007-12-13 19:31       ` J. Bruce Fields
2007-12-17  9:53         ` Tom Tucker
2007-12-11 23:32   ` [PATCH 07/38] svc: Add per-transport delete functions Tom Tucker
2007-12-11 23:32   ` [PATCH 08/38] svc: Add xpo_prep_reply_hdr Tom Tucker
2007-12-11 23:32   ` [PATCH 09/38] svc: Add a transport function that checks for write space Tom Tucker
     [not found]     ` <20071211233212.15718.69282.stgit-gUwIgmpLGaKNDNWfRnPdfg@public.gmane.org>
2007-12-12 18:10       ` Chuck Lever
2007-12-12 20:00         ` Tom Tucker
2007-12-13 21:33         ` J. Bruce Fields
2007-12-13 21:45           ` Chuck Lever
2007-12-13 22:20             ` Tom Tucker
     [not found]               ` <1197584427.6348.10.camel-SMNkleLxa3ZimH42XvhXlA@public.gmane.org>
2007-12-13 22:28                 ` J. Bruce Fields
2007-12-14 13:59                   ` Chuck Lever
2007-12-14 14:27                 ` Chuck Lever
2007-12-11 23:32   ` [PATCH 10/38] svc: Move close processing to a single place Tom Tucker
2007-12-11 23:32   ` [PATCH 11/38] svc: Add xpo_accept transport function Tom Tucker
     [not found]     ` <20071211233217.15718.14380.stgit-gUwIgmpLGaKNDNWfRnPdfg@public.gmane.org>
2007-12-14 19:01       ` J. Bruce Fields
2007-12-14 19:14         ` Tom Tucker
2007-12-17 10:02         ` Tom Tucker
2007-12-14 19:55       ` J. Bruce Fields
2007-12-15  5:22         ` Tom Tucker
2007-12-17 10:49         ` Tom Tucker
2007-12-11 23:32   ` [PATCH 12/38] svc: Add a generic transport svc_create_xprt function Tom Tucker
2007-12-11 23:32   ` [PATCH 13/38] svc: Change services to use new svc_create_xprt service Tom Tucker
2007-12-11 23:32   ` [PATCH 14/38] svc: Change sk_inuse to a kref Tom Tucker
     [not found]     ` <20071211233224.15718.91339.stgit-gUwIgmpLGaKNDNWfRnPdfg@public.gmane.org>
2007-12-14 20:52       ` J. Bruce Fields
2007-12-15 20:28         ` Tom Tucker
2007-12-11 23:32   ` [PATCH 15/38] svc: Move sk_flags to the svc_xprt structure Tom Tucker
2007-12-11 23:32   ` [PATCH 16/38] svc: Move sk_server and sk_pool to svc_xprt Tom Tucker
2007-12-11 23:32   ` [PATCH 17/38] svc: Make close transport independent Tom Tucker
2007-12-11 23:32   ` [PATCH 18/38] svc: Move sk_reserved to svc_xprt Tom Tucker
2007-12-11 23:32   ` [PATCH 19/38] svc: Make the enqueue service transport neutral and export it Tom Tucker
2007-12-11 23:32   ` [PATCH 20/38] svc: Make svc_send transport neutral Tom Tucker
2007-12-11 23:32   ` [PATCH 21/38] svc: Change svc_sock_received to svc_xprt_received and export it Tom Tucker
2007-12-11 23:32   ` [PATCH 22/38] svc: Move accept call to svc_xprt_received to common code Tom Tucker
2007-12-11 23:32   ` [PATCH 23/38] svc: Remove sk_lastrecv Tom Tucker
2007-12-11 23:32   ` [PATCH 24/38] svc: Move the authinfo cache to svc_xprt Tom Tucker
2007-12-11 23:32   ` [PATCH 25/38] svc: Make deferral processing xprt independent Tom Tucker
2007-12-11 23:32   ` [PATCH 26/38] svc: Move the sockaddr information to svc_xprt Tom Tucker
2007-12-11 23:32   ` [PATCH 27/38] svc: Make svc_sock_release svc_xprt_release Tom Tucker
2007-12-11 23:32   ` [PATCH 28/38] svc: Make svc_recv transport neutral Tom Tucker
2007-12-11 23:32   ` [PATCH 29/38] svc: Make svc_age_temp_sockets svc_age_temp_transports Tom Tucker
2007-12-11 23:33   ` [PATCH 30/38] svc: Move common create logic to common code Tom Tucker
     [not found]     ` <20071211233300.15718.30136.stgit-gUwIgmpLGaKNDNWfRnPdfg@public.gmane.org>
2007-12-14 23:19       ` J. Bruce Fields
2007-12-15 22:14         ` Tom Tucker
2007-12-17 15:27         ` Tom Tucker
2007-12-11 23:33   ` [PATCH 31/38] svc: Removing remaining references to rq_sock in rqstp Tom Tucker
2007-12-11 23:33   ` [PATCH 32/38] svc: Make svc_check_conn_limits xprt independent Tom Tucker
2007-12-11 23:33   ` [PATCH 33/38] svc: Move the xprt independent code to the svc_xprt.c file Tom Tucker
2007-12-11 23:33   ` [PATCH 34/38] svc: Add transport hdr size for defer/revisit Tom Tucker
     [not found]     ` <20071211233309.15718.84852.stgit-gUwIgmpLGaKNDNWfRnPdfg@public.gmane.org>
2007-12-14 23:37       ` J. Bruce Fields
2007-12-15 18:16         ` Tom Tucker [this message]
2007-12-11 23:33   ` [PATCH 35/38] svc: Add /proc/sys/sunrpc/transport files Tom Tucker
2007-12-11 23:33   ` [PATCH 36/38] svc: Add svc API that queries for a transport instance Tom Tucker
2007-12-11 23:33   ` [PATCH 37/38] knfsd: Support adding transports by writing portlist file Tom Tucker
     [not found]     ` <20071211233316.15718.85089.stgit-gUwIgmpLGaKNDNWfRnPdfg@public.gmane.org>
2007-12-14 23:51       ` J. Bruce Fields
2007-12-21 17:52         ` Tom Tucker
     [not found]           ` <1198259550.14237.33.camel-SMNkleLxa3ZimH42XvhXlA@public.gmane.org>
2008-01-03 21:13             ` J. Bruce Fields
2008-01-08 17:45               ` Tom Tucker
2007-12-11 23:33   ` [PATCH 38/38] svc: Add svc_xprt_names service to replace svc_sock_names Tom Tucker
     [not found]     ` <20071211233318.15718.11614.stgit-gUwIgmpLGaKNDNWfRnPdfg@public.gmane.org>
2007-12-15  0:03       ` J. Bruce Fields
2007-12-21 17:51         ` Tom Tucker
     [not found]           ` <1198259507.14237.31.camel-SMNkleLxa3ZimH42XvhXlA@public.gmane.org>
2008-01-03 21:14             ` J. Bruce Fields
2008-01-04  0:47               ` Neil Brown
     [not found]                 ` <18301.33306.486417.193770-wvvUuzkyo1EYVZTmpyfIwg@public.gmane.org>
2008-01-14 13:27                   ` Tom Tucker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=C3897600.22993%tom@opengridcomputing.com \
    --to=tom@opengridcomputing.com \
    --cc=bfields@fieldses.org \
    --cc=linux-nfs@vger.kernel.org \
    --cc=neilb@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox