From: Jeff Layton <jlayton@redhat.com>
To: Trond Myklebust <trond.myklebust@fys.uio.no>
Cc: Christoph Hellwig <hch@infradead.org>,
linux-nfs@vger.kernel.org, nfsv4@linux-nfs.org
Subject: Re: [PATCH] NFS: flush signals before taking down callback thread
Date: Wed, 20 Feb 2008 09:01:10 -0500 [thread overview]
Message-ID: <20080220090110.5658c78e@barsoom.rdu.redhat.com> (raw)
In-Reply-To: <1203461010.13265.12.camel-rJ7iovZKK19ZJLDQqaL3InhyD016LWXt@public.gmane.org>
On Tue, 19 Feb 2008 17:43:30 -0500
Trond Myklebust <trond.myklebust@fys.uio.no> wrote:
>
> On Tue, 2008-02-19 at 17:22 -0500, Christoph Hellwig wrote:
> > Wouldn't it be better to not allow for signals to this thread at
> > all? The code really begs for a similar kthread conversion as the
> > lockd one.
>
> I'd tend to prefer that solution too.
>
I did a bit of smoke testing on that patch this morning and just sent
it out to the list. The only problem is that that patch depends on a
couple of other patches currently in Bruce's tree and that are slated
for 2.6.26. It might be reasonable in the interim to go ahead and take
the patch to flush_signals() in the existing code.
Thanks,
--
Jeff Layton <jlayton@redhat.com>
next prev parent reply other threads:[~2008-02-20 14:01 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-19 17:51 [PATCH] NFS: flush signals before taking down callback thread Jeff Layton
2008-02-19 22:22 ` Christoph Hellwig
2008-02-19 22:43 ` Trond Myklebust
[not found] ` <1203461010.13265.12.camel-rJ7iovZKK19ZJLDQqaL3InhyD016LWXt@public.gmane.org>
2008-02-20 14:01 ` Jeff Layton [this message]
[not found] ` <20080220090110.5658c78e-xSBYVWDuneFaJnirhKH9O4GKTjYczspe@public.gmane.org>
2008-02-20 15:10 ` Trond Myklebust
2008-02-19 23:00 ` Jeff Layton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080220090110.5658c78e@barsoom.rdu.redhat.com \
--to=jlayton@redhat.com \
--cc=hch@infradead.org \
--cc=linux-nfs@vger.kernel.org \
--cc=nfsv4@linux-nfs.org \
--cc=trond.myklebust@fys.uio.no \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox