Linux NFS development
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: Jeff Layton <jlayton@redhat.com>
Cc: Trond Myklebust <trond.myklebust@fys.uio.no>,
	linux-nfs@vger.kernel.org, nfsv4@linux-nfs.org
Subject: Re: [PATCH] NFS: flush signals before taking down callback thread
Date: Tue, 19 Feb 2008 17:22:26 -0500	[thread overview]
Message-ID: <20080219222226.GA10656@infradead.org> (raw)
In-Reply-To: <1203443495-7854-1-git-send-email-jlayton@redhat.com>

On Tue, Feb 19, 2008 at 12:51:35PM -0500, Jeff Layton wrote:
> Now that the reference counting on the callback thread is working as
> expected, it uncovers another problem.  Peter Staubach noticed while
> testing that patch on an older kernel that he would occasionally see
> this printk in rpc_register fire:
> 
>     "RPC: failed to contact portmap (errno -512).
> 
> The NFSv4 callback thread is signaled by nfs_callback_down(), but never
> flushes that signal. All of the shutdown processing is done with that
> signal pending. This makes it fail the call to unregister the port with
> the portmapper.
> 
> In actuality, this rpc_register call isn't necessary at all since the
> port isn't actually registered with the portmapper anymore. Regardless,
> there doesn't seem to be any reason to leave the signal pending while
> the thread is being shut down and flushing it should generally silence
> that printk.

Wouldn't it be better to not allow for signals to this thread at all?
The code really begs for a similar kthread conversion as the lockd one.

  reply	other threads:[~2008-02-19 22:22 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-19 17:51 [PATCH] NFS: flush signals before taking down callback thread Jeff Layton
2008-02-19 22:22 ` Christoph Hellwig [this message]
2008-02-19 22:43   ` Trond Myklebust
     [not found]     ` <1203461010.13265.12.camel-rJ7iovZKK19ZJLDQqaL3InhyD016LWXt@public.gmane.org>
2008-02-20 14:01       ` Jeff Layton
     [not found]         ` <20080220090110.5658c78e-xSBYVWDuneFaJnirhKH9O4GKTjYczspe@public.gmane.org>
2008-02-20 15:10           ` Trond Myklebust
2008-02-19 23:00   ` Jeff Layton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080219222226.GA10656@infradead.org \
    --to=hch@infradead.org \
    --cc=jlayton@redhat.com \
    --cc=linux-nfs@vger.kernel.org \
    --cc=nfsv4@linux-nfs.org \
    --cc=trond.myklebust@fys.uio.no \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox