Linux NFS development
 help / color / mirror / Atom feed
* [PATCH] NFS: flush signals before taking down callback thread
@ 2008-02-19 17:51 Jeff Layton
  2008-02-19 22:22 ` Christoph Hellwig
  0 siblings, 1 reply; 6+ messages in thread
From: Jeff Layton @ 2008-02-19 17:51 UTC (permalink / raw)
  To: Trond Myklebust; +Cc: linux-nfs, nfsv4

Now that the reference counting on the callback thread is working as
expected, it uncovers another problem.  Peter Staubach noticed while
testing that patch on an older kernel that he would occasionally see
this printk in rpc_register fire:

    "RPC: failed to contact portmap (errno -512).

The NFSv4 callback thread is signaled by nfs_callback_down(), but never
flushes that signal. All of the shutdown processing is done with that
signal pending. This makes it fail the call to unregister the port with
the portmapper.

In actuality, this rpc_register call isn't necessary at all since the
port isn't actually registered with the portmapper anymore. Regardless,
there doesn't seem to be any reason to leave the signal pending while
the thread is being shut down and flushing it should generally silence
that printk.

Signed-off-by: Jeff Layton <jlayton@redhat.com>
---
 fs/nfs/callback.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/fs/nfs/callback.c b/fs/nfs/callback.c
index ecc06c6..0d784f6 100644
--- a/fs/nfs/callback.c
+++ b/fs/nfs/callback.c
@@ -93,6 +93,7 @@ static void nfs_callback_svc(struct svc_rqst *rqstp)
 		svc_process(rqstp);
 	}
 
+	flush_signals(current);
 	svc_exit_thread(rqstp);
 	nfs_callback_info.pid = 0;
 	complete(&nfs_callback_info.stopped);
-- 
1.5.3.8

^ permalink raw reply related	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2008-02-20 15:10 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-02-19 17:51 [PATCH] NFS: flush signals before taking down callback thread Jeff Layton
2008-02-19 22:22 ` Christoph Hellwig
2008-02-19 22:43   ` Trond Myklebust
     [not found]     ` <1203461010.13265.12.camel-rJ7iovZKK19ZJLDQqaL3InhyD016LWXt@public.gmane.org>
2008-02-20 14:01       ` Jeff Layton
     [not found]         ` <20080220090110.5658c78e-xSBYVWDuneFaJnirhKH9O4GKTjYczspe@public.gmane.org>
2008-02-20 15:10           ` Trond Myklebust
2008-02-19 23:00   ` Jeff Layton

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox