Linux NFS development
 help / color / mirror / Atom feed
* [patch for 2.6.27? 1/1] nfs: BUG_ON in nfs_follow_mountpoint
@ 2008-09-02 21:48 akpm
  0 siblings, 0 replies; only message in thread
From: akpm @ 2008-09-02 21:48 UTC (permalink / raw)
  To: trond.myklebust; +Cc: bfields, linux-nfs, akpm, den, Trond.Myklebust

From: "Denis V. Lunev" <den@openvz.org>

Unfortunately, BUG_ON(IS_ROOT(dentry)) can happen inside
nfs_follow_mountpoint with NFS running Fedora 8 using a specific setup.

See https://bugzilla.redhat.com/show_bug.cgi?id=458622

So the situation should be handled on NFS client gracefully.

Signed-off-by: Denis V. Lunev <den@openvz.org>
Cc: Trond Myklebust <Trond.Myklebust@netapp.com>
Cc: J. Bruce Fields <bfields@fieldses.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---

 fs/nfs/namespace.c |    5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff -puN fs/nfs/namespace.c~nfs-bug_on-in-nfs_follow_mountpoint fs/nfs/namespace.c
--- a/fs/nfs/namespace.c~nfs-bug_on-in-nfs_follow_mountpoint
+++ a/fs/nfs/namespace.c
@@ -105,7 +105,10 @@ static void * nfs_follow_mountpoint(stru
 
 	dprintk("--> nfs_follow_mountpoint()\n");
 
-	BUG_ON(IS_ROOT(dentry));
+	err = -ESTALE;
+	if (IS_ROOT(dentry))
+		goto out_err;
+
 	dprintk("%s: enter\n", __func__);
 	dput(nd->path.dentry);
 	nd->path.dentry = dget(dentry);
_

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2008-09-02 21:49 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-09-02 21:48 [patch for 2.6.27? 1/1] nfs: BUG_ON in nfs_follow_mountpoint akpm

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox