Re: [PATCH] net/sunrpc/xprtsock.c: some common code found

["J. Bruce Fields" <bfields@fieldses.org>]

On Tue, Feb 10, 2009 at 03:20:36PM +0200, Ilpo J=C3=A4rvinen wrote:
> On Sun, 8 Feb 2009, J. Bruce Fields wrote:
>=20
> > (Where's diff-func from?)
>=20
> My own tool collection. I can make it available if you want to.

Sure, I'd be curious.

--b.

>=20
> > In similar cases in the future, if you want to cater to the more ti=
red
> > and/or mentally challenged among us (which may just be me), some cl=
ue
> > that visually distinguishes the quoted diff output in the comment m=
ight
> > help; e.g., maybe indent it like the below.
> >=20
> > (But that's intended as a suggestion, not a requirement.)
>=20
> Yeah, a good idea... I'll sed some spaces in front of them in the fut=
ure=20
> to make the difference more obvious. The expected outcome though is t=
hat=20
> somebody probably then hits reply button too soon claiming that the p=
atch=20
> is broken :-).
>=20
>=20
> --=20
>  i.