From: Al Viro <viro@ZenIV.linux.org.uk>
To: Benny Halevy <bhalevy@panasas.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
Andrew Morton <akpm@linux-foundation.org>,
Christoph Hellwig <hch@infradead.org>,
"J. Bruce Fields" <bfields@fieldses.org>,
Trond Myklebust <trond.myklebust@fys.uio.no>,
linux-nfs@vger.kernel.org, linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH] EXPORT_SYMBOL(d_obtain_alias) rather than EXPORT_SYMBOL_GPL
Date: Tue, 24 Feb 2009 21:32:22 +0000 [thread overview]
Message-ID: <20090224213222.GH28946@ZenIV.linux.org.uk> (raw)
In-Reply-To: <49A4547E.90607@panasas.com>
On Tue, Feb 24, 2009 at 12:11:42PM -0800, Benny Halevy wrote:
> Commit 4ea3ada2955e4519befa98ff55dd62d6dfbd1705
> declares d_obtain_alias() as EXPORT_SYMBOL_GPL
> where it's supposed to replace d_alloc_anon which
> was previously declared as EXPORT_SYMBOL and thus
> available to any loadable module.
>
> This patch reverts that, as discussed below:
ACK. d_obtain_alias() makes sense as a general-purpose interface, period.
As an aside, EXPORT_SYMBOL_GPL() is obnoxious shite anyway. If
something is not a safe API, exporting it to default-quality 3rd-party
code is bad and while GPL might be many things, it is not a magical
"teach average programmer to find his arse without a map" pill.
next prev parent reply other threads:[~2009-02-24 21:32 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-21 7:13 Ping: d_obtain_alias Benny Halevy
2009-02-21 17:40 ` Christoph Hellwig
2009-02-21 8:41 ` Benny Halevy
2009-02-21 19:40 ` Andrew Morton
2009-02-21 19:49 ` Linus Torvalds
2009-02-24 20:11 ` [PATCH] EXPORT_SYMBOL(d_obtain_alias) rather than EXPORT_SYMBOL_GPL Benny Halevy
2009-02-24 21:32 ` Al Viro [this message]
2009-02-24 21:36 ` Linus Torvalds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090224213222.GH28946@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=akpm@linux-foundation.org \
--cc=bfields@fieldses.org \
--cc=bhalevy@panasas.com \
--cc=hch@infradead.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=trond.myklebust@fys.uio.no \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox