Linux NFS development
 help / color / mirror / Atom feed
From: Benny Halevy <bhalevy@panasas.com>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	Christoph Hellwig <hch@infradead.org>,
	"J. Bruce Fields" <bfields@fieldses.org>,
	Trond Myklebust <trond.myklebust@fys.uio.no>,
	linux-nfs@vger.kernel.org, linux-fsdevel@vger.kernel.org,
	Al Viro <viro@zeniv.linux.org.uk>
Subject: [PATCH] EXPORT_SYMBOL(d_obtain_alias) rather than EXPORT_SYMBOL_GPL
Date: Tue, 24 Feb 2009 12:11:42 -0800	[thread overview]
Message-ID: <49A4547E.90607@panasas.com> (raw)
In-Reply-To: <alpine.LFD.2.00.0902211146400.3111@localhost.localdomain>

Commit 4ea3ada2955e4519befa98ff55dd62d6dfbd1705
declares d_obtain_alias() as EXPORT_SYMBOL_GPL
where it's supposed to replace d_alloc_anon which
was previously declared as EXPORT_SYMBOL and thus
available to any loadable module.

This patch reverts that, as discussed below:

On Feb. 21, 2009, 11:40 -0800, Andrew Morton <akpm@linux-foundation.org> wrote:
> On Sat, 21 Feb 2009 12:40:46 -0500 Christoph Hellwig <hch@infradead.org> wrote:
...
>> All the nfs exported filesystem are tied intimately to the kernel,
>> so yes, this is an internal export.
>>
>> Non-GPL filesystem are illegal to distribute anyway, so I don't know why
>> you even bother.
>>
>
> Here's the patch in question:
...
> Neither the title nor the changelog mentioned anything about disabling
> non-GPL filesystems, so this effect was a mistake.  I didn't know this
> was the effect and I doubt if Linus knew and quite possibly Christoph
> and Al didn't know either.
>
> We should correct that mistake.  Afterwards, feel free to prepare and
> send out a patch titled "[patch] disable non-GPL filesystems" and we
> can discuss it.

On Feb. 21, 2009, 11:49 -0800, Linus Torvalds <torvalds@linux-foundation.org> wrote:
>
> On Sat, 21 Feb 2009, Andrew Morton wrote:
>> Here's the patch in question:
>
> .. or perhaps 9308a6128d9074e348d9f9b5822546fe12a794a9, which actually did
> the "Remove d_alloc_anon now that no users are left.".
>
> I do agree - if people are now expected to convert from d_alloc_anon() to
> d_obtain_alias(), then we can't just go and change license requirements
> under them.
>
> Some religious argument doesn't change that, or override technical
> reasoning. If people are still using d_alloc_anon(), we should either
> re-export it, or just export d_obtain_alias() in a usable form for them.
>
> 		Linus

Signed-off-by: Benny Halevy <bhalevy@panasas.com>
---
 fs/dcache.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/fs/dcache.c b/fs/dcache.c
index 937df0f..07e2d4a 100644
--- a/fs/dcache.c
+++ b/fs/dcache.c
@@ -1180,7 +1180,7 @@ struct dentry *d_obtain_alias(struct inode *inode)
 	iput(inode);
 	return res;
 }
-EXPORT_SYMBOL_GPL(d_obtain_alias);
+EXPORT_SYMBOL(d_obtain_alias);
 
 /**
  * d_splice_alias - splice a disconnected dentry into the tree if one exists
-- 
1.6.1.3



  reply	other threads:[~2009-02-24 20:11 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-02-21  7:13 Ping: d_obtain_alias Benny Halevy
2009-02-21 17:40 ` Christoph Hellwig
2009-02-21  8:41   ` Benny Halevy
2009-02-21 19:40   ` Andrew Morton
2009-02-21 19:49     ` Linus Torvalds
2009-02-24 20:11       ` Benny Halevy [this message]
2009-02-24 21:32         ` [PATCH] EXPORT_SYMBOL(d_obtain_alias) rather than EXPORT_SYMBOL_GPL Al Viro
2009-02-24 21:36           ` Linus Torvalds

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=49A4547E.90607@panasas.com \
    --to=bhalevy@panasas.com \
    --cc=akpm@linux-foundation.org \
    --cc=bfields@fieldses.org \
    --cc=hch@infradead.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-nfs@vger.kernel.org \
    --cc=torvalds@linux-foundation.org \
    --cc=trond.myklebust@fys.uio.no \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox