From: "J. Bruce Fields" <bfields@fieldses.org>
To: Chuck Lever <chuck.lever@oracle.com>
Cc: Jeff Layton <jlayton@redhat.com>,
NFS list <linux-nfs@vger.kernel.org>,
Linux NFSv4 mailing list <nfsv4@linux-nfs.org>
Subject: Re: [PATCH 0/6] nfsd: add support for NFSv4 callbacks over IPv6 (try #5)
Date: Fri, 21 Aug 2009 11:44:04 -0400 [thread overview]
Message-ID: <20090821154404.GD18318@fieldses.org> (raw)
In-Reply-To: <D24FC53A-3E15-444F-BCDF-BE8454205B4F@oracle.com>
On Fri, Aug 14, 2009 at 02:05:03PM -0400, Chuck Lever wrote:
> On Aug 14, 2009, at 12:57 PM, Jeff Layton wrote:
>> Fifth attempt at a patchset to add support for NFSv4 callbacks over
>> IPv6. Changes from last patchset are mostly to address Chuck's
>> comments:
>>
>> 1) made the new address comparison and copy routines into static
>> inlines
>> and added them to clnt.h. Ditto for the get_scope_id function.
>>
>> 2) combined the patch to change nfs4_cb_conn to hold address in
>> sockaddr_storage with the one to convert gen_callback to use
>> rpc_uaddr2sockaddr. That eliminates changes to the parse_ipv4 function
>> that eventually gets ripped out.
>>
>> Tested using opensolaris and linux and verifying that delegations
>> could
>> be properly recalled. I also tested mounts to the server's link-local
>> address and verified that the callback channel connected correctly.
>
> Looks good.
>
> Acked-by: Chuck Lever <chuck.lever@oracle.com>
Applied, thanks to you both.
--b.
prev parent reply other threads:[~2009-08-21 15:44 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-14 16:57 [PATCH 0/6] nfsd: add support for NFSv4 callbacks over IPv6 (try #5) Jeff Layton
2009-08-14 16:57 ` [PATCH 1/6] sunrpc: add routine for comparing addresses Jeff Layton
2009-08-14 16:57 ` [PATCH 2/6] sunrpc: add common routine for copying address portion of a sockaddr Jeff Layton
2009-08-14 16:57 ` [PATCH 3/6] nfsd: make nfs4_client->cl_addr a struct sockaddr_storage Jeff Layton
2009-08-14 16:57 ` [PATCH 4/6] nfsd: convert nfs4_cb_conn struct to hold address in sockaddr_storage Jeff Layton
2009-08-14 16:57 ` [PATCH 5/6] nfsd: add support for NFSv4 callbacks over IPv6 Jeff Layton
2009-08-14 16:57 ` [PATCH 6/6] nfsd: populate sin6_scope_id on callback address with scopeid from rq_addr on SETCLIENTID call Jeff Layton
2009-08-14 18:05 ` [PATCH 0/6] nfsd: add support for NFSv4 callbacks over IPv6 (try #5) Chuck Lever
2009-08-21 15:44 ` J. Bruce Fields [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090821154404.GD18318@fieldses.org \
--to=bfields@fieldses.org \
--cc=chuck.lever@oracle.com \
--cc=jlayton@redhat.com \
--cc=linux-nfs@vger.kernel.org \
--cc=nfsv4@linux-nfs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox