From: NeilBrown <neilb@suse.de>
To: Trond Myklebust <Trond.Myklebust@netapp.com>
Cc: linux-nfs@vger.kernel.org, NeilBrown <neilb@suse.de>
Subject: [PATCH 2/2] NFS: honour preferred rsize/wsize reported by server.
Date: Tue, 17 Nov 2009 15:21:24 +1100 [thread overview]
Message-ID: <20091117042124.1563.32006.stgit@notabene.brown> (raw)
In-Reply-To: <20091117042004.1563.95871.stgit-wvvUuzkyo1EYVZTmpyfIwg@public.gmane.org>
When a filesystem is mounted with ASCII mount options, and no rsize
or wsize is given, the client should default to using the preferred
sizes reported in the FSINFO request.
However it does not. These values are initialised to
NFS_MAX_FILE_IO_SIZE and as they are now non-zero, the default does
not get applied.
So initialise to 0 thus allowing appropriate defaults to apply.
Signed-off-by: NeilBrown <neilb@suse.de>
---
fs/nfs/super.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/fs/nfs/super.c b/fs/nfs/super.c
index 90be551..18c5f85 100644
--- a/fs/nfs/super.c
+++ b/fs/nfs/super.c
@@ -734,8 +734,8 @@ static struct nfs_parsed_mount_data *nfs_alloc_parsed_mount_data(unsigned int ve
data = kzalloc(sizeof(*data), GFP_KERNEL);
if (data) {
- data->rsize = NFS_MAX_FILE_IO_SIZE;
- data->wsize = NFS_MAX_FILE_IO_SIZE;
+ data->rsize = 0;
+ data->wsize = 0;
data->acregmin = NFS_DEF_ACREGMIN;
data->acregmax = NFS_DEF_ACREGMAX;
data->acdirmin = NFS_DEF_ACDIRMIN;
next prev parent reply other threads:[~2009-11-17 4:21 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-17 4:21 [PATCH 0/2] Some fixes for NFS NeilBrown
[not found] ` <20091117042004.1563.95871.stgit-wvvUuzkyo1EYVZTmpyfIwg@public.gmane.org>
2009-11-17 4:21 ` NeilBrown [this message]
2009-11-17 4:21 ` [PATCH 1/2] NFS4ERR_FILE_OPEN handling in Linux/NFS NeilBrown
[not found] ` <20091117042123.1563.20912.stgit-wvvUuzkyo1EYVZTmpyfIwg@public.gmane.org>
2009-11-20 19:58 ` Trond Myklebust
2009-11-24 2:56 ` Neil Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091117042124.1563.32006.stgit@notabene.brown \
--to=neilb@suse.de \
--cc=Trond.Myklebust@netapp.com \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox