public inbox for linux-nfs@vger.kernel.org
 help / color / mirror / Atom feed
From: Neil Brown <neilb@suse.de>
To: "J. Bruce Fields" <bfields@fieldses.org>
Cc: Steve Dickson <SteveD@redhat.com>, linux-nfs@vger.kernel.org
Subject: Re: [nfs-utils PATCH] retry on EPERM from NFSv4 mount attempt
Date: Tue, 1 Dec 2009 08:59:16 +1100	[thread overview]
Message-ID: <20091201085916.7c1bb644@notabene.brown> (raw)
In-Reply-To: <20091130181858.GA6348@fieldses.org>

On Mon, 30 Nov 2009 13:18:58 -0500
"J. Bruce Fields" <bfields@fieldses.org> wrote:

> Note we want to do more than one of these; in particular:
> 
> >    1) Start servers with '-N 4' when there is no root configured.  
> 
> This is required.  The current behavior is a bug, and we must not
> start servers with v4 support without having a pseudoroot.

Yes, you could describe the current behaviour as a bug, but I don't
think it necessarily follows than encouraging the use of "-N 4" is an
appropriate resolution to the bug.  I agree with Steve that that would
seem like a backwards step.

Completing the auto-pseudo-root work and getting that active would also
fix the bug, and would do it in a more forward-looking way.

So while there may be a case of advising people (in a FAQ?) that using 
-N4 might be appropriate if no fsid=root is configured, I don't think
there is any point in trying to make it a default through making
any changes to the nfs-utils packages.

> >    2) Change the kernel to return NFS4ERR_SERVERFAULT when there is no
> >       root configured. 
> >       * I see this is yet another errno the mounting code has to deal with..
> >         We are up to two errnos, do we really want to add a third?  
>
> I think SERVERFAULT is a little more accurate, but I'm open to argument.

I think SERVERFAULT is the only vaguely relevant error permitted by the
RFC, so it think that should be returned.
As I said previously, I think mount.nfs should fall-back from v4 to v3
on any error when no specific version has been requested.

NeilBrown

  reply	other threads:[~2009-11-30 21:57 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-23 23:32 [nfs-utils PATCH] retry on EPERM from NFSv4 mount attempt Neil Brown
     [not found] ` <19211.7054.291514.185591-wvvUuzkyo1EYVZTmpyfIwg@public.gmane.org>
2009-11-24 14:29   ` Steve Dickson
     [not found]     ` <4B0BEDDB.1010203-AfCzQyP5zfLQT0dZR+AlfA@public.gmane.org>
2009-11-24 20:56       ` J. Bruce Fields
2009-11-24 21:19         ` Peter Staubach
2009-11-24 21:51         ` Neil Brown
     [not found]           ` <20091125085122.316f4eb3-wvvUuzkyo1EYVZTmpyfIwg@public.gmane.org>
2009-11-24 21:58             ` Peter Staubach
2009-11-24 22:22               ` Neil Brown
     [not found]                 ` <20091125092227.77735d5a-wvvUuzkyo1EYVZTmpyfIwg@public.gmane.org>
2009-11-24 22:29                   ` Peter Staubach
2009-11-24 22:54                     ` J. Bruce Fields
2009-11-24 22:58                   ` Trond Myklebust
2009-11-30 13:11       ` Steve Dickson
     [not found]         ` <4B13C48E.5020009-AfCzQyP5zfLQT0dZR+AlfA@public.gmane.org>
2009-11-30 16:43           ` Chuck Lever
2009-11-30 17:41             ` Steve Dickson
     [not found]               ` <4B1403CA.8050107-AfCzQyP5zfLQT0dZR+AlfA@public.gmane.org>
2009-11-30 17:52                 ` Chuck Lever
2009-11-30 18:12                   ` Steve Dickson
2009-11-30 18:18           ` J. Bruce Fields
2009-11-30 21:59             ` Neil Brown [this message]
     [not found]               ` <20091201085916.7c1bb644-wvvUuzkyo1EYVZTmpyfIwg@public.gmane.org>
2009-11-30 22:13                 ` J. Bruce Fields
2009-12-07 22:27   ` Steve Dickson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091201085916.7c1bb644@notabene.brown \
    --to=neilb@suse.de \
    --cc=SteveD@redhat.com \
    --cc=bfields@fieldses.org \
    --cc=linux-nfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox