From: akpm@linux-foundation.org
To: Trond.Myklebust@netapp.com
Cc: linux-nfs@vger.kernel.org, akpm@linux-foundation.org,
raa.lkml@gmail.com, cel@citi.umich.edu, davem@davemloft.net,
tmtalpey@gmail.com
Subject: [patch 1/1] sunrpc: use formatting of module name in SUNRPC
Date: Mon, 21 Dec 2009 16:26:20 -0800 [thread overview]
Message-ID: <200912220026.nBM0QKjh005180@imap1.linux-foundation.org> (raw)
From: Alex Riesen <raa.lkml@gmail.com>
gcc-4.3.3 produces the warning:
"format not a string literal and no format arguments"
Signed-off-by: Alex Riesen <raa.lkml@gmail.com>
Cc: Trond Myklebust <Trond.Myklebust@netapp.com>
Cc: Chuck Lever <cel@citi.umich.edu>
Cc: David S. Miller <davem@davemloft.net>
Acked-by: Tom Talpey <tmtalpey@gmail.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---
net/sunrpc/xprt.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff -puN net/sunrpc/xprt.c~sunrpc-use-formatting-of-module-name-in-sunrpc net/sunrpc/xprt.c
--- a/net/sunrpc/xprt.c~sunrpc-use-formatting-of-module-name-in-sunrpc
+++ a/net/sunrpc/xprt.c
@@ -165,7 +165,6 @@ EXPORT_SYMBOL_GPL(xprt_unregister_transp
int xprt_load_transport(const char *transport_name)
{
struct xprt_class *t;
- char module_name[sizeof t->name + 5];
int result;
result = 0;
@@ -177,9 +176,7 @@ int xprt_load_transport(const char *tran
}
}
spin_unlock(&xprt_list_lock);
- strcpy(module_name, "xprt");
- strncat(module_name, transport_name, sizeof t->name);
- result = request_module(module_name);
+ result = request_module("xprt%s", transport_name);
out:
return result;
}
_
next reply other threads:[~2009-12-22 0:26 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-22 0:26 akpm [this message]
-- strict thread matches above, loose matches on Subject: below --
2010-04-27 21:15 [patch 1/1] sunrpc: use formatting of module name in SUNRPC akpm
[not found] ` <201004272115.o3RLFnKj020353-AB4EexQrvXRQetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org>
2010-04-28 7:40 ` Alex Riesen
[not found] ` <l2l81b0412b1004280040t415657c7qe7de59f152cd49aa-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2010-04-28 11:39 ` Andrew Morton
2010-04-28 19:49 ` Alex Riesen
2009-11-17 22:46 akpm
2009-09-18 19:54 akpm
2009-08-06 23:07 akpm
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200912220026.nBM0QKjh005180@imap1.linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=Trond.Myklebust@netapp.com \
--cc=cel@citi.umich.edu \
--cc=davem@davemloft.net \
--cc=linux-nfs@vger.kernel.org \
--cc=raa.lkml@gmail.com \
--cc=tmtalpey@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox