[patch 1/1] sunrpc: use formatting of module name in SUNRPC

public inbox for linux-nfs@vger.kernel.org
 help / color / mirror / Atom feed

* [patch 1/1] sunrpc: use formatting of module name in SUNRPC
@ 2009-12-22  0:26 akpm
  0 siblings, 0 replies; 8+ messages in thread
From: akpm @ 2009-12-22  0:26 UTC (permalink / raw)
  To: Trond.Myklebust; +Cc: linux-nfs, akpm, raa.lkml, cel, davem, tmtalpey

From: Alex Riesen <raa.lkml@gmail.com>

gcc-4.3.3 produces the warning:
  "format not a string literal and no format arguments"

Signed-off-by: Alex Riesen <raa.lkml@gmail.com>
Cc: Trond Myklebust <Trond.Myklebust@netapp.com>
Cc: Chuck Lever <cel@citi.umich.edu>
Cc: David S. Miller <davem@davemloft.net>
Acked-by: Tom Talpey <tmtalpey@gmail.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---

 net/sunrpc/xprt.c |    5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff -puN net/sunrpc/xprt.c~sunrpc-use-formatting-of-module-name-in-sunrpc net/sunrpc/xprt.c
--- a/net/sunrpc/xprt.c~sunrpc-use-formatting-of-module-name-in-sunrpc
+++ a/net/sunrpc/xprt.c
@@ -165,7 +165,6 @@ EXPORT_SYMBOL_GPL(xprt_unregister_transp
 int xprt_load_transport(const char *transport_name)
 {
 	struct xprt_class *t;
-	char module_name[sizeof t->name + 5];
 	int result;
 
 	result = 0;
@@ -177,9 +176,7 @@ int xprt_load_transport(const char *tran
 		}
 	}
 	spin_unlock(&xprt_list_lock);
-	strcpy(module_name, "xprt");
-	strncat(module_name, transport_name, sizeof t->name);
-	result = request_module(module_name);
+	result = request_module("xprt%s", transport_name);
 out:
 	return result;
 }
_

^ permalink raw reply	[flat|nested] 8+ messages in thread

* [patch 1/1] sunrpc: use formatting of module name in SUNRPC
@ 2010-04-27 21:15 akpm
       [not found] ` <201004272115.o3RLFnKj020353-AB4EexQrvXRQetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org>
  0 siblings, 1 reply; 8+ messages in thread
From: akpm @ 2010-04-27 21:15 UTC (permalink / raw)
  To: trond.myklebust
  Cc: linux-nfs, akpm, raa.lkml, Trond.Myklebust, cel, davem, tmtalpey

From: Alex Riesen <raa.lkml@gmail.com>

gcc-4.3.3 produces the warning:
  "format not a string literal and no format arguments"

Signed-off-by: Alex Riesen <raa.lkml@gmail.com>
Cc: Trond Myklebust <Trond.Myklebust@netapp.com>
Cc: Chuck Lever <cel@citi.umich.edu>
Cc: David S. Miller <davem@davemloft.net>
Acked-by: Tom Talpey <tmtalpey@gmail.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---

 net/sunrpc/xprt.c |    5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff -puN net/sunrpc/xprt.c~sunrpc-use-formatting-of-module-name-in-sunrpc net/sunrpc/xprt.c
--- a/net/sunrpc/xprt.c~sunrpc-use-formatting-of-module-name-in-sunrpc
+++ a/net/sunrpc/xprt.c
@@ -165,7 +165,6 @@ EXPORT_SYMBOL_GPL(xprt_unregister_transp
 int xprt_load_transport(const char *transport_name)
 {
 	struct xprt_class *t;
-	char module_name[sizeof t->name + 5];
 	int result;
 
 	result = 0;
@@ -177,9 +176,7 @@ int xprt_load_transport(const char *tran
 		}
 	}
 	spin_unlock(&xprt_list_lock);
-	strcpy(module_name, "xprt");
-	strncat(module_name, transport_name, sizeof t->name);
-	result = request_module(module_name);
+	result = request_module("xprt%s", transport_name);
 out:
 	return result;
 }
_

^ permalink raw reply	[flat|nested] 8+ messages in thread

[parent not found: <201004272115.o3RLFnKj020353-AB4EexQrvXRQetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org>]

* Re: [patch 1/1] sunrpc: use formatting of module name in SUNRPC
       [not found] ` <201004272115.o3RLFnKj020353-AB4EexQrvXRQetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org>
@ 2010-04-28  7:40   ` Alex Riesen
       [not found]     ` <l2l81b0412b1004280040t415657c7qe7de59f152cd49aa-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
  0 siblings, 1 reply; 8+ messages in thread
From: Alex Riesen @ 2010-04-28  7:40 UTC (permalink / raw)
  To: Linux Kernel Mailing List
  Cc: trond.myklebust, linux-nfs, Trond.Myklebust, cel, davem, tmtalpey,
	akpm

On Tue, Apr 27, 2010 at 23:15,  <akpm@linux-foundation.org> wrote:
> From: Alex Riesen <raa.lkml@gmail.com>
>
> gcc-4.3.3 produces the warning:
> =C2=A0"format not a string literal and no format arguments"
>
> Signed-off-by: Alex Riesen <raa.lkml@gmail.com>
> Cc: Trond Myklebust <Trond.Myklebust@netapp.com>
> Cc: Chuck Lever <cel@citi.umich.edu>
> Cc: David S. Miller <davem@davemloft.net>
> Acked-by: Tom Talpey <tmtalpey@gmail.com>
> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
> ---
>
> =C2=A0net/sunrpc/xprt.c | =C2=A0 =C2=A05 +----
> =C2=A01 file changed, 1 insertion(+), 4 deletions(-)
>

This is one tough little patch... 2 years and counting...

^ permalink raw reply	[flat|nested] 8+ messages in thread

[parent not found: <l2l81b0412b1004280040t415657c7qe7de59f152cd49aa-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>]

* Re: [patch 1/1] sunrpc: use formatting of module name in SUNRPC
       [not found]     ` <l2l81b0412b1004280040t415657c7qe7de59f152cd49aa-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
@ 2010-04-28 11:39       ` Andrew Morton
  2010-04-28 19:49         ` Alex Riesen
  0 siblings, 1 reply; 8+ messages in thread
From: Andrew Morton @ 2010-04-28 11:39 UTC (permalink / raw)
  To: Alex Riesen
  Cc: Linux Kernel Mailing List, trond.myklebust, linux-nfs,
	Trond.Myklebust, cel, davem, tmtalpey

On Wed, 28 Apr 2010 09:40:36 +0200 Alex Riesen <raa.lkml@gmail.com> wrote:

> On Tue, Apr 27, 2010 at 23:15,  <akpm@linux-foundation.org> wrote:
> > From: Alex Riesen <raa.lkml@gmail.com>
> >
> > gcc-4.3.3 produces the warning:
> > __"format not a string literal and no format arguments"
> >
> > Signed-off-by: Alex Riesen <raa.lkml@gmail.com>
> > Cc: Trond Myklebust <Trond.Myklebust@netapp.com>
> > Cc: Chuck Lever <cel@citi.umich.edu>
> > Cc: David S. Miller <davem@davemloft.net>
> > Acked-by: Tom Talpey <tmtalpey@gmail.com>
> > Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
> > ---
> >
> > __net/sunrpc/xprt.c | __ __5 +----
> > __1 file changed, 1 insertion(+), 4 deletions(-)
> >
> 
> This is one tough little patch... 2 years and counting...

heh.  I've only had it since June '09.

I'll merge it into 2.6.35-rc1.

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [patch 1/1] sunrpc: use formatting of module name in SUNRPC
  2010-04-28 11:39       ` Andrew Morton
@ 2010-04-28 19:49         ` Alex Riesen
  0 siblings, 0 replies; 8+ messages in thread
From: Alex Riesen @ 2010-04-28 19:49 UTC (permalink / raw)
  To: Andrew Morton
  Cc: Linux Kernel Mailing List, trond.myklebust, linux-nfs,
	Trond.Myklebust, cel, davem, tmtalpey

On Wed, Apr 28, 2010 at 13:39, Andrew Morton <akpm@linux-foundation.org=
> wrote:
> On Wed, 28 Apr 2010 09:40:36 +0200 Alex Riesen <raa.lkml@gmail.com> w=
rote:
>> > __net/sunrpc/xprt.c | __ __5 +----
>> > __1 file changed, 1 insertion(+), 4 deletions(-)
>> >
>>
>> This is one tough little patch... 2 years and counting...
>
> heh. =C2=A0I've only had it since June '09.
>
> I'll merge it into 2.6.35-rc1.
>

That's because I was overly pessimistic. gcc-4.3.3 only exists since
24 Jan, 2009.
I just have the change (and other request_module name formatting patche=
s)
in my trees already for quite some time...

^ permalink raw reply	[flat|nested] 8+ messages in thread

* [patch 1/1] sunrpc: use formatting of module name in SUNRPC
@ 2009-11-17 22:46 akpm
  0 siblings, 0 replies; 8+ messages in thread
From: akpm @ 2009-11-17 22:46 UTC (permalink / raw)
  To: trond.myklebust
  Cc: linux-nfs, akpm, raa.lkml, Trond.Myklebust, cel, davem, tmtalpey

From: Alex Riesen <raa.lkml@gmail.com>

gcc-4.3.3 produces the warning:
  "format not a string literal and no format arguments"

Signed-off-by: Alex Riesen <raa.lkml@gmail.com>
Cc: Trond Myklebust <Trond.Myklebust@netapp.com>
Cc: Chuck Lever <cel@citi.umich.edu>
Cc: David S. Miller <davem@davemloft.net>
Acked-by: Tom Talpey <tmtalpey@gmail.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---

 net/sunrpc/xprt.c |    5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff -puN net/sunrpc/xprt.c~sunrpc-use-formatting-of-module-name-in-sunrpc net/sunrpc/xprt.c
--- a/net/sunrpc/xprt.c~sunrpc-use-formatting-of-module-name-in-sunrpc
+++ a/net/sunrpc/xprt.c
@@ -165,7 +165,6 @@ EXPORT_SYMBOL_GPL(xprt_unregister_transp
 int xprt_load_transport(const char *transport_name)
 {
 	struct xprt_class *t;
-	char module_name[sizeof t->name + 5];
 	int result;
 
 	result = 0;
@@ -177,9 +176,7 @@ int xprt_load_transport(const char *tran
 		}
 	}
 	spin_unlock(&xprt_list_lock);
-	strcpy(module_name, "xprt");
-	strncat(module_name, transport_name, sizeof t->name);
-	result = request_module(module_name);
+	result = request_module("xprt%s", transport_name);
 out:
 	return result;
 }
_

^ permalink raw reply	[flat|nested] 8+ messages in thread

* [patch 1/1] sunrpc: use formatting of module name in SUNRPC
@ 2009-09-18 19:54 akpm
  0 siblings, 0 replies; 8+ messages in thread
From: akpm @ 2009-09-18 19:54 UTC (permalink / raw)
  To: trond.myklebust
  Cc: linux-nfs, akpm, raa.lkml, Trond.Myklebust, cel, davem, tmtalpey

From: Alex Riesen <raa.lkml@gmail.com>

gcc-4.3.3 produces the warning:
  "format not a string literal and no format arguments"

Signed-off-by: Alex Riesen <raa.lkml@gmail.com>
Cc: Trond Myklebust <Trond.Myklebust@netapp.com>
Cc: Chuck Lever <cel@citi.umich.edu>
Cc: David S. Miller <davem@davemloft.net>
Acked-by: Tom Talpey <tmtalpey@gmail.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---

 net/sunrpc/xprt.c |    5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff -puN net/sunrpc/xprt.c~sunrpc-use-formatting-of-module-name-in-sunrpc net/sunrpc/xprt.c
--- a/net/sunrpc/xprt.c~sunrpc-use-formatting-of-module-name-in-sunrpc
+++ a/net/sunrpc/xprt.c
@@ -165,7 +165,6 @@ EXPORT_SYMBOL_GPL(xprt_unregister_transp
 int xprt_load_transport(const char *transport_name)
 {
 	struct xprt_class *t;
-	char module_name[sizeof t->name + 5];
 	int result;
 
 	result = 0;
@@ -177,9 +176,7 @@ int xprt_load_transport(const char *tran
 		}
 	}
 	spin_unlock(&xprt_list_lock);
-	strcpy(module_name, "xprt");
-	strncat(module_name, transport_name, sizeof t->name);
-	result = request_module(module_name);
+	result = request_module("xprt%s", transport_name);
 out:
 	return result;
 }
_

^ permalink raw reply	[flat|nested] 8+ messages in thread

* [patch 1/1] sunrpc: use formatting of module name in SUNRPC
@ 2009-08-06 23:07 akpm
  0 siblings, 0 replies; 8+ messages in thread
From: akpm @ 2009-08-06 23:07 UTC (permalink / raw)
  To: trond.myklebust
  Cc: linux-nfs, akpm, raa.lkml, Trond.Myklebust, cel, davem, tmtalpey

From: Alex Riesen <raa.lkml@gmail.com>

gcc-4.3.3 produces the warning:
  "format not a string literal and no format arguments"

Signed-off-by: Alex Riesen <raa.lkml@gmail.com>
Cc: Trond Myklebust <Trond.Myklebust@netapp.com>
Cc: Chuck Lever <cel@citi.umich.edu>
Cc: David S. Miller <davem@davemloft.net>
Acked-by: Tom Talpey <tmtalpey@gmail.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---

 net/sunrpc/xprt.c |    5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff -puN net/sunrpc/xprt.c~sunrpc-use-formatting-of-module-name-in-sunrpc net/sunrpc/xprt.c
--- a/net/sunrpc/xprt.c~sunrpc-use-formatting-of-module-name-in-sunrpc
+++ a/net/sunrpc/xprt.c
@@ -165,7 +165,6 @@ EXPORT_SYMBOL_GPL(xprt_unregister_transp
 int xprt_load_transport(const char *transport_name)
 {
 	struct xprt_class *t;
-	char module_name[sizeof t->name + 5];
 	int result;
 
 	result = 0;
@@ -177,9 +176,7 @@ int xprt_load_transport(const char *tran
 		}
 	}
 	spin_unlock(&xprt_list_lock);
-	strcpy(module_name, "xprt");
-	strncat(module_name, transport_name, sizeof t->name);
-	result = request_module(module_name);
+	result = request_module("xprt%s", transport_name);
 out:
 	return result;
 }
_

^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2010-04-28 19:49 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-12-22  0:26 [patch 1/1] sunrpc: use formatting of module name in SUNRPC akpm
  -- strict thread matches above, loose matches on Subject: below --
2010-04-27 21:15 akpm
     [not found] ` <201004272115.o3RLFnKj020353-AB4EexQrvXRQetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org>
2010-04-28  7:40   ` Alex Riesen
     [not found]     ` <l2l81b0412b1004280040t415657c7qe7de59f152cd49aa-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2010-04-28 11:39       ` Andrew Morton
2010-04-28 19:49         ` Alex Riesen
2009-11-17 22:46 akpm
2009-09-18 19:54 akpm
2009-08-06 23:07 akpm

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox