From: "J. Bruce Fields" <bfields@fieldses.org>
To: Jeff Layton <jlayton@redhat.com>
Cc: steved@redhat.com, chuck.lever@oracle.com, linux-nfs@vger.kernel.org
Subject: Re: [PATCH 0/3] nfs-utils: add testing infrastructure to nfs-utils (try #3)
Date: Wed, 6 Jan 2010 14:58:19 -0500 [thread overview]
Message-ID: <20100106195819.GH6612@fieldses.org> (raw)
In-Reply-To: <20100106144247.18dc10de-9yPaYZwiELC+kQycOl6kW4xkIHaj4LzF@public.gmane.org>
On Wed, Jan 06, 2010 at 02:42:47PM -0500, Jeff Layton wrote:
> On Wed, 6 Jan 2010 14:17:06 -0500
> "J. Bruce Fields" <bfields@fieldses.org> wrote:
>
> > This probably just shows I'm not reading carefully, but: are you
> > requiring root, and messing with their existing nfs configuration at
> > all?
> >
> > For the export stuff it would also be great to have some tests that set
> > up a few dummy exports (using tmpfs?) and tried to mount them (just over
> > loopback), but I'd be afraid someone would try to run "make check" on
> > their production server. So I'm not sure where to put that kind of
> > test.
> >
>
> The script I have so far doesn't check for root privs, but it won't
> work unless you have them since statd will fail to start. statd
> currently requires root privs to start though it does drop them soon
> afterward.
>
> I'm open to suggestions on changing this as I'm not crazy about that
> either.
My feeling is that it will be hard to find a realistic way to test
everything without having root and taking over the machine to some
degree.
Just so long as the user understands whether it needs to be run as root,
whether it's safe to be run on a host connected to the network, etc....
I don't know if 'make check' is the right ui for that.
--b.
next prev parent reply other threads:[~2010-01-06 19:57 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-05 15:40 [PATCH 0/3] nfs-utils: add testing infrastructure to nfs-utils (try #3) Jeff Layton
2010-01-05 15:40 ` [PATCH 1/3] nfs-utils: introduce new statd testing simulator Jeff Layton
2010-01-05 15:40 ` [PATCH 2/3] nfs-utils: add statdb_dump utility Jeff Layton
2010-01-05 16:09 ` Chuck Lever
2010-01-05 19:17 ` Jeff Layton
[not found] ` <20100105141732.4590bcce-9yPaYZwiELC+kQycOl6kW4xkIHaj4LzF@public.gmane.org>
2010-01-05 19:25 ` Chuck Lever
2010-01-05 15:40 ` [PATCH 3/3] nfs-utils: add initial tests for statd that run via "make check" Jeff Layton
2010-01-05 16:37 ` Steve Dickson
[not found] ` <4B436AD3.2080107-AfCzQyP5zfLQT0dZR+AlfA@public.gmane.org>
2010-01-05 18:25 ` Jeff Layton
[not found] ` <20100105132519.02c3c76d-9yPaYZwiELC+kQycOl6kW4xkIHaj4LzF@public.gmane.org>
2010-01-05 21:29 ` Jeff Layton
2010-01-06 19:17 ` [PATCH 0/3] nfs-utils: add testing infrastructure to nfs-utils (try #3) J. Bruce Fields
2010-01-06 19:42 ` Jeff Layton
[not found] ` <20100106144247.18dc10de-9yPaYZwiELC+kQycOl6kW4xkIHaj4LzF@public.gmane.org>
2010-01-06 19:58 ` J. Bruce Fields [this message]
2010-01-06 20:10 ` Jeff Layton
2010-01-06 20:22 ` Chuck Lever
2010-01-06 20:33 ` J. Bruce Fields
2010-01-07 14:18 ` Jeff Layton
[not found] ` <20100107091832.687cb7eb-xSBYVWDuneFaJnirhKH9O4GKTjYczspe@public.gmane.org>
2010-01-08 5:05 ` J. Bruce Fields
2010-01-08 12:03 ` Jeff Layton
2010-01-08 14:51 ` Jeff Layton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100106195819.GH6612@fieldses.org \
--to=bfields@fieldses.org \
--cc=chuck.lever@oracle.com \
--cc=jlayton@redhat.com \
--cc=linux-nfs@vger.kernel.org \
--cc=steved@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox