From: Steve Dickson <SteveD@redhat.com>
To: Jeff Layton <jlayton@redhat.com>
Cc: chuck.lever@oracle.com, linux-nfs@vger.kernel.org
Subject: Re: [PATCH 3/3] nfs-utils: add initial tests for statd that run via "make check"
Date: Tue, 05 Jan 2010 11:37:39 -0500 [thread overview]
Message-ID: <4B436AD3.2080107@RedHat.com> (raw)
In-Reply-To: <1262706035-4929-4-git-send-email-jlayton@redhat.com>
On 01/05/2010 10:40 AM, Jeff Layton wrote:
> Leverage the support that automake already has for running tests via
> make check. Add a simple test that just checks that the statd mon and
> unmon calls actually work.
>
> Adding more tests should be a simple matter of adding new scripts
> exit 0 on success and non-zero on fail, and adding those to the
> Makefile.am.
>
> Signed-off-by: Jeff Layton <jlayton@redhat.com>
> ---
> tests/Makefile.am | 2 +
> tests/t0001-statd-basic-mon-unmon.sh | 55 ++++++++++++++++++++++++++++++++++
> tests/test-lib.sh | 41 +++++++++++++++++++++++++
> 3 files changed, 98 insertions(+), 0 deletions(-)
> create mode 100755 tests/t0001-statd-basic-mon-unmon.sh
> create mode 100755 tests/test-lib.sh
>
> diff --git a/tests/Makefile.am b/tests/Makefile.am
> index a20b42b..faa8197 100644
> --- a/tests/Makefile.am
> +++ b/tests/Makefile.am
> @@ -9,3 +9,5 @@ statdb_dump_LDADD = ../support/nfs/libnfs.a \
> SUBDIRS = nsm_client
>
> MAINTAINERCLEANFILES = Makefile.in
> +
> +TESTS = t0001-statd-basic-mon-unmon.sh
> diff --git a/tests/t0001-statd-basic-mon-unmon.sh b/tests/t0001-statd-basic-mon-unmon.sh
> new file mode 100755
> index 0000000..6e0b869
> --- /dev/null
> +++ b/tests/t0001-statd-basic-mon-unmon.sh
> @@ -0,0 +1,55 @@
> +#!/bin/bash
> +#
> +# statd_basic_mon_unmon -- test basic mon/unmon functionality with statd
> +#
> +# Copyright (C) 2010 Red Hat, Jeff Layton <jlayton@redhat.com>
> +#
> +# This program is free software; you can redistribute it and/or
> +# modify it under the terms of the GNU General Public License
> +# as published by the Free Software Foundation; either version 2
> +# of the License, or (at your option) any later version.
> +#
> +# This program is distributed in the hope that it will be useful,
> +# but WITHOUT ANY WARRANTY; without even the implied warranty of
> +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
> +# GNU General Public License for more details.
> +#
> +# You should have received a copy of the GNU General Public License
> +# along with this program; if not, write to the Free Software Foundation, Inc.,
> +# 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
> +#
> +
> +. ./test-lib.sh
> +
> +start_statd
> +if [ $? -ne 0 ]; then
> + echo "FAIL: problem starting statd"
> + exit 1
> +fi
> +
> +COOKIE=`echo $$ | md5sum | cut -d' ' -f1`
> +MON_NAME=`hostname`
> +
> +nsm_client mon $MON_NAME $COOKIE
> +if [ $? -ne 0 ]; then
> + echo "FAIL: mon failed"
> + kill_statd
> + exit 1
> +fi
> +
> +./statdb_dump | grep $MON_NAME | grep -q $COOKIE
> +if [ $? -ne 0 ]; then
> + echo "FAIL: monitor DB doesn't seem to contain entry"
> + kill_statd
> + exit 1
> +fi
> +
> +nsm_client unmon $MON_NAME
> +if [ $? -ne 0 ]; then
> + echo "FAIL: unmon failed"
> + kill_statd
> + exit 1
> +fi
> +
> +kill_statd
> +
> diff --git a/tests/test-lib.sh b/tests/test-lib.sh
> new file mode 100755
> index 0000000..e509859
> --- /dev/null
> +++ b/tests/test-lib.sh
> @@ -0,0 +1,41 @@
> +#!/bin/bash
> +#
> +# test-lib.sh -- library of functions for nfs-utils tests
> +#
> +# Copyright (C) 2010 Red Hat, Jeff Layton <jlayton@redhat.com>
> +#
> +# This program is free software; you can redistribute it and/or
> +# modify it under the terms of the GNU General Public License
> +# as published by the Free Software Foundation; either version 2
> +# of the License, or (at your option) any later version.
> +#
> +# This program is distributed in the hope that it will be useful,
> +# but WITHOUT ANY WARRANTY; without even the implied warranty of
> +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
> +# GNU General Public License for more details.
> +#
> +# You should have received a copy of the GNU General Public License
> +# along with this program; if not, write to the Free Software Foundation, Inc.,
> +# 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
> +#
> +
> +export PATH=$PATH:$srcdir/nsm_client
How or Where is '$srcdir' set??
steved.
next prev parent reply other threads:[~2010-01-05 16:37 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-05 15:40 [PATCH 0/3] nfs-utils: add testing infrastructure to nfs-utils (try #3) Jeff Layton
2010-01-05 15:40 ` [PATCH 1/3] nfs-utils: introduce new statd testing simulator Jeff Layton
2010-01-05 15:40 ` [PATCH 2/3] nfs-utils: add statdb_dump utility Jeff Layton
2010-01-05 16:09 ` Chuck Lever
2010-01-05 19:17 ` Jeff Layton
[not found] ` <20100105141732.4590bcce-9yPaYZwiELC+kQycOl6kW4xkIHaj4LzF@public.gmane.org>
2010-01-05 19:25 ` Chuck Lever
2010-01-05 15:40 ` [PATCH 3/3] nfs-utils: add initial tests for statd that run via "make check" Jeff Layton
2010-01-05 16:37 ` Steve Dickson [this message]
[not found] ` <4B436AD3.2080107-AfCzQyP5zfLQT0dZR+AlfA@public.gmane.org>
2010-01-05 18:25 ` Jeff Layton
[not found] ` <20100105132519.02c3c76d-9yPaYZwiELC+kQycOl6kW4xkIHaj4LzF@public.gmane.org>
2010-01-05 21:29 ` Jeff Layton
2010-01-06 19:17 ` [PATCH 0/3] nfs-utils: add testing infrastructure to nfs-utils (try #3) J. Bruce Fields
2010-01-06 19:42 ` Jeff Layton
[not found] ` <20100106144247.18dc10de-9yPaYZwiELC+kQycOl6kW4xkIHaj4LzF@public.gmane.org>
2010-01-06 19:58 ` J. Bruce Fields
2010-01-06 20:10 ` Jeff Layton
2010-01-06 20:22 ` Chuck Lever
2010-01-06 20:33 ` J. Bruce Fields
2010-01-07 14:18 ` Jeff Layton
[not found] ` <20100107091832.687cb7eb-xSBYVWDuneFaJnirhKH9O4GKTjYczspe@public.gmane.org>
2010-01-08 5:05 ` J. Bruce Fields
2010-01-08 12:03 ` Jeff Layton
2010-01-08 14:51 ` Jeff Layton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B436AD3.2080107@RedHat.com \
--to=steved@redhat.com \
--cc=chuck.lever@oracle.com \
--cc=jlayton@redhat.com \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox