From: Christoph Hellwig <hch@infradead.org>
To: Trond Myklebust <Trond.Myklebust@netapp.com>
Cc: Christoph Hellwig <hch@infradead.org>,
"Dr. J. Bruce Fields" <bfields@fieldses.org>,
linux-nfs@vger.kernel.org
Subject: Re: nfsd: Use vfs_fsync_range() in nfsd_commit
Date: Fri, 29 Jan 2010 16:27:06 -0500 [thread overview]
Message-ID: <20100129212706.GA28361@infradead.org> (raw)
In-Reply-To: <1264799906.3644.21.camel@localhost>
On Fri, Jan 29, 2010 at 04:18:26PM -0500, Trond Myklebust wrote:
> nfsd: Use vfs_fsync_range() in nfsd_commit
>
> From: Trond Myklebust <Trond.Myklebust@netapp.com>
>
> The NFS COMMIT operation allows the client to specify the exact byte range
> that it wishes to sync to disk in order to optimise server performance.
>
> Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>
Looks good to me,
Reviewed-by: Christoph Hellwig <hch@lst.de>
> * Commit all pending writes to stable storage.
> - * Strictly speaking, we could sync just the indicated file region here,
> - * but there's currently no way we can ask the VFS to do so.
The commit above could use some addition that the commit only happens
for the specified range.
And not actually touched by your patch, but that is the reason to
open/close the file if we don't actually do anything with it for an
async export?
next prev parent reply other threads:[~2010-01-29 21:27 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-29 20:19 nfsd: Replace nfsd_sync() with vfs_fsync() and vfs_fsync_range() Trond Myklebust
2010-01-29 20:35 ` Trond Myklebust
2010-01-29 20:44 ` [PATCH v2] " Trond Myklebust
2010-01-29 20:50 ` Christoph Hellwig
2010-01-29 20:57 ` Trond Myklebust
2010-01-29 21:18 ` nfsd: Use vfs_fsync_range() in nfsd_commit Trond Myklebust
2010-01-29 21:27 ` Christoph Hellwig [this message]
2010-01-29 21:39 ` Trond Myklebust
2010-01-29 23:58 ` Dr. J. Bruce Fields
2010-03-17 19:08 ` Jeff Layton
[not found] ` <20100317150813.43815b5a-9yPaYZwiELC+kQycOl6kW4xkIHaj4LzF@public.gmane.org>
2010-03-17 19:35 ` Trond Myklebust
2010-01-29 21:44 ` [PATCH v4] " Trond Myklebust
2010-01-29 23:53 ` Dr. J. Bruce Fields
2010-01-29 23:54 ` Dr. J. Bruce Fields
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100129212706.GA28361@infradead.org \
--to=hch@infradead.org \
--cc=Trond.Myklebust@netapp.com \
--cc=bfields@fieldses.org \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox