From: "Dr. J. Bruce Fields" <bfields@fieldses.org>
To: Trond Myklebust <Trond.Myklebust@netapp.com>
Cc: Christoph Hellwig <hch@infradead.org>, linux-nfs@vger.kernel.org
Subject: Re: nfsd: Use vfs_fsync_range() in nfsd_commit
Date: Fri, 29 Jan 2010 18:58:52 -0500 [thread overview]
Message-ID: <20100129235852.GC30852@fieldses.org> (raw)
In-Reply-To: <1264801151.3644.27.camel@localhost>
On Fri, Jan 29, 2010 at 04:39:11PM -0500, Trond Myklebust wrote:
> On Fri, 2010-01-29 at 16:27 -0500, Christoph Hellwig wrote:
> > And not actually touched by your patch, but that is the reason to
> > open/close the file if we don't actually do anything with it for an
> > async export?
>
> I must admit that I was wondering about that too. I'm assuming that the
> reason is to provide consistent behaviour w.r.t. access checks and
> possibly also to ensure that NFSv4 delegations are revoked. Perhaps
> Bruce could comment?
Do delegations need to be revoked on commit? (And do we care about
access checks?)
We could do both without the need for an actual open, but I don't know
that it matters much either way.
--b.
next prev parent reply other threads:[~2010-01-29 23:58 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-29 20:19 nfsd: Replace nfsd_sync() with vfs_fsync() and vfs_fsync_range() Trond Myklebust
2010-01-29 20:35 ` Trond Myklebust
2010-01-29 20:44 ` [PATCH v2] " Trond Myklebust
2010-01-29 20:50 ` Christoph Hellwig
2010-01-29 20:57 ` Trond Myklebust
2010-01-29 21:18 ` nfsd: Use vfs_fsync_range() in nfsd_commit Trond Myklebust
2010-01-29 21:27 ` Christoph Hellwig
2010-01-29 21:39 ` Trond Myklebust
2010-01-29 23:58 ` Dr. J. Bruce Fields [this message]
2010-03-17 19:08 ` Jeff Layton
[not found] ` <20100317150813.43815b5a-9yPaYZwiELC+kQycOl6kW4xkIHaj4LzF@public.gmane.org>
2010-03-17 19:35 ` Trond Myklebust
2010-01-29 21:44 ` [PATCH v4] " Trond Myklebust
2010-01-29 23:53 ` Dr. J. Bruce Fields
2010-01-29 23:54 ` Dr. J. Bruce Fields
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100129235852.GC30852@fieldses.org \
--to=bfields@fieldses.org \
--cc=Trond.Myklebust@netapp.com \
--cc=hch@infradead.org \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox