From: "J. Bruce Fields" <bfields@fieldses.org>
To: Trond Myklebust <Trond.Myklebust@netapp.com>
Cc: "Mr. Steve Dickson" <SteveD@redhat.com>, linux-nfs@vger.kernel.org
Subject: Re: [PATCH][nfs-utils] configuration: Fix a typo in configure.ac
Date: Mon, 22 Feb 2010 13:22:02 -0500 [thread overview]
Message-ID: <20100222182202.GB11356@fieldses.org> (raw)
In-Reply-To: <1266709510.3507.1.camel-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
On Sat, Feb 20, 2010 at 03:45:10PM -0800, Trond Myklebust wrote:
> From: Trond Myklebust <Trond.Myklebust@netapp.com>
>
> Fix a typo in commit 6d5ac3fa (nfsd: Disble NFS 4.1 functionality by default).
Better: please just rever 6d5ac3fa and apply
http://marc.info/?l=linux-nfs&m=126540028610022&w=2
- distributions shouldn't be turning on 4.1 by default yet.
Even if no clients *use* it by default, future clients will,
even with older servers that shouldn't have had 4.1 on yet.
- In addition to the bug Trond found, 6d5ac3fa also
inadvertently disables -N4 in the disable_nfsv41 case.
--b.
>
> We did not really intend to make NFSv4.0 support conditional on NFSv4.1
> being enabled.
>
> Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>
> ---
>
> configure.ac | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
>
> diff --git a/configure.ac b/configure.ac
> index b7520d8..518b6d8 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -81,7 +81,7 @@ AC_ARG_ENABLE(nfsv41,
> if test "$enable_nfsv41" = yes; then
> AC_DEFINE(NFS41_SUPPORTED, 1, [Define this if you want NFSv41 support compiled in])
> else
> - enable_nfsv4=
> + enable_nfsv41=
> fi
> AC_SUBST(enable_nfsv41)
> AM_CONDITIONAL(CONFIG_NFSV41, [test "$enable_nfsv41" = "yes"])
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2010-02-22 18:21 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-20 23:45 [PATCH][nfs-utils] configuration: Fix a typo in configure.ac Trond Myklebust
[not found] ` <1266709510.3507.1.camel-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2010-02-22 18:22 ` J. Bruce Fields [this message]
2010-03-01 12:57 ` Steve Dickson
[not found] ` <4B8BB9B8.8040703-AfCzQyP5zfLQT0dZR+AlfA@public.gmane.org>
2010-03-01 13:25 ` J. Bruce Fields
2010-03-01 13:48 ` Steve Dickson
[not found] ` <4B8BC5B9.1020304-AfCzQyP5zfLQT0dZR+AlfA@public.gmane.org>
2010-03-01 13:55 ` J. Bruce Fields
2010-03-01 14:13 ` Steve Dickson
[not found] ` <4B8BCB7D.1030202-AfCzQyP5zfLQT0dZR+AlfA@public.gmane.org>
2010-03-01 14:22 ` J. Bruce Fields
2010-03-01 12:41 ` Steve Dickson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100222182202.GB11356@fieldses.org \
--to=bfields@fieldses.org \
--cc=SteveD@redhat.com \
--cc=Trond.Myklebust@netapp.com \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox