From: Steve Dickson <SteveD@redhat.com>
To: "J. Bruce Fields" <bfields@fieldses.org>
Cc: Trond Myklebust <Trond.Myklebust@netapp.com>, linux-nfs@vger.kernel.org
Subject: Re: [PATCH][nfs-utils] configuration: Fix a typo in configure.ac
Date: Mon, 01 Mar 2010 07:57:28 -0500 [thread overview]
Message-ID: <4B8BB9B8.8040703@RedHat.com> (raw)
In-Reply-To: <20100222182202.GB11356@fieldses.org>
On 02/22/2010 01:22 PM, J. Bruce Fields wrote:
> On Sat, Feb 20, 2010 at 03:45:10PM -0800, Trond Myklebust wrote:
>> From: Trond Myklebust <Trond.Myklebust@netapp.com>
>>
>> Fix a typo in commit 6d5ac3fa (nfsd: Disble NFS 4.1 functionality by default).
>
> Better: please just rever 6d5ac3fa and apply
> http://marc.info/?l=linux-nfs&m=126540028610022&w=2
The problem I saw with the this patch was it would take
a code change to re-enable the 4.1 functional, verses a
enabling a configuration flag. Plus, there has been a
precedence set of having these types of configuration flags,
note the enable_nfsv3, enable_nfsv4, so adding a enable_nfsv41
seem to me made sense...
>
> - distributions shouldn't be turning on 4.1 by default yet.
Its not... If the --enable_nfsv41 is not set, the 4.1 functional is
off. Having this type of flag enables the distros to enable the
functionality on development kernels but disable it on stable
kernels, without any additional patches. Again to me, its seems
like the cleanest way to do it...
> - In addition to the bug Trond found, 6d5ac3fa also
> inadvertently disables -N4 in the disable_nfsv41 case.
Fixed...
steved.
next prev parent reply other threads:[~2010-03-01 12:57 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-20 23:45 [PATCH][nfs-utils] configuration: Fix a typo in configure.ac Trond Myklebust
[not found] ` <1266709510.3507.1.camel-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2010-02-22 18:22 ` J. Bruce Fields
2010-03-01 12:57 ` Steve Dickson [this message]
[not found] ` <4B8BB9B8.8040703-AfCzQyP5zfLQT0dZR+AlfA@public.gmane.org>
2010-03-01 13:25 ` J. Bruce Fields
2010-03-01 13:48 ` Steve Dickson
[not found] ` <4B8BC5B9.1020304-AfCzQyP5zfLQT0dZR+AlfA@public.gmane.org>
2010-03-01 13:55 ` J. Bruce Fields
2010-03-01 14:13 ` Steve Dickson
[not found] ` <4B8BCB7D.1030202-AfCzQyP5zfLQT0dZR+AlfA@public.gmane.org>
2010-03-01 14:22 ` J. Bruce Fields
2010-03-01 12:41 ` Steve Dickson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B8BB9B8.8040703@RedHat.com \
--to=steved@redhat.com \
--cc=Trond.Myklebust@netapp.com \
--cc=bfields@fieldses.org \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox