* [PATCH] NFSD: NFSv4 callback client should use RPC_TASK_SOFTCONN
@ 2010-02-24 21:48 Chuck Lever
[not found] ` <20100224214709.1399.59887.stgit-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
0 siblings, 1 reply; 2+ messages in thread
From: Chuck Lever @ 2010-02-24 21:48 UTC (permalink / raw)
To: bfields; +Cc: linux-nfs
The server's callback client should stop trying to connect to the
client's callback server as soon as it gets ECONNREFUSED.
The NFS server's callback client does not call rpc_ping(), but appears
to have it's own "ping" procedure, so it wasn't covered by commit
caabea8a.
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
---
Hi Bruce-
Noticed at Connectathon. I think this is appropriate for 2.6.34, which opened
today.
fs/nfsd/nfs4callback.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/fs/nfsd/nfs4callback.c b/fs/nfsd/nfs4callback.c
index c6eed2a..5ab598d 100644
--- a/fs/nfsd/nfs4callback.c
+++ b/fs/nfsd/nfs4callback.c
@@ -542,7 +542,8 @@ void do_probe_callback(struct nfs4_client *clp)
};
int status;
- status = rpc_call_async(cb->cb_client, &msg, RPC_TASK_SOFT,
+ status = rpc_call_async(cb->cb_client, &msg,
+ RPC_TASK_SOFT | RPC_TASK_SOFTCONN,
&nfsd4_cb_probe_ops, (void *)clp);
if (status) {
warn_no_callback_path(clp, status);
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] NFSD: NFSv4 callback client should use RPC_TASK_SOFTCONN
[not found] ` <20100224214709.1399.59887.stgit-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
@ 2010-02-25 1:51 ` J. Bruce Fields
0 siblings, 0 replies; 2+ messages in thread
From: J. Bruce Fields @ 2010-02-25 1:51 UTC (permalink / raw)
To: Chuck Lever; +Cc: linux-nfs
On Wed, Feb 24, 2010 at 01:48:06PM -0800, Chuck Lever wrote:
> The server's callback client should stop trying to connect to the
> client's callback server as soon as it gets ECONNREFUSED.
>
> The NFS server's callback client does not call rpc_ping(), but appears
> to have it's own "ping" procedure, so it wasn't covered by commit
> caabea8a.
>
> Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
> ---
>
> Hi Bruce-
>
> Noticed at Connectathon. I think this is appropriate for 2.6.34, which opened
> today.
Thanks, applied for 2.6.34.
--b.
>
> fs/nfsd/nfs4callback.c | 3 ++-
> 1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/fs/nfsd/nfs4callback.c b/fs/nfsd/nfs4callback.c
> index c6eed2a..5ab598d 100644
> --- a/fs/nfsd/nfs4callback.c
> +++ b/fs/nfsd/nfs4callback.c
> @@ -542,7 +542,8 @@ void do_probe_callback(struct nfs4_client *clp)
> };
> int status;
>
> - status = rpc_call_async(cb->cb_client, &msg, RPC_TASK_SOFT,
> + status = rpc_call_async(cb->cb_client, &msg,
> + RPC_TASK_SOFT | RPC_TASK_SOFTCONN,
> &nfsd4_cb_probe_ops, (void *)clp);
> if (status) {
> warn_no_callback_path(clp, status);
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-02-25 1:50 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-02-24 21:48 [PATCH] NFSD: NFSv4 callback client should use RPC_TASK_SOFTCONN Chuck Lever
[not found] ` <20100224214709.1399.59887.stgit-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2010-02-25 1:51 ` J. Bruce Fields
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox