* [PATCH] mount: Mount should retry unreachable hosts
@ 2010-03-10 21:42 Chuck Lever
[not found] ` <20100310214136.3002.78499.stgit-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
0 siblings, 1 reply; 2+ messages in thread
From: Chuck Lever @ 2010-03-10 21:42 UTC (permalink / raw)
To: steved; +Cc: linux-nfs
Currently if a server is up but not responding (ie, it answers ARP
requests, but not NFS or RPC requests), mount retries or backgrounds
itself waiting for the server.
If the server is not responding on the network at all, mount fails
the mount request immediately.
Users might find it more useful if mount retried in both cases.
Note that this change means attempting to mount using a misspelled
server name will "hang" for the retry amount. I suppose the error
message isn't very helpful whether it fails immediately or waits
a couple of minutes, though I imagine that an unreachable server is a
much more common occurrence than a misspelling.
Reported-by: Daniel Goering <g_daniel@gmx.net>
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
---
utils/mount/stropts.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/utils/mount/stropts.c b/utils/mount/stropts.c
index 9b8c38f..98557d2 100644
--- a/utils/mount/stropts.c
+++ b/utils/mount/stropts.c
@@ -799,6 +799,7 @@ static int nfs_is_permanent_error(int error)
case ESTALE:
case ETIMEDOUT:
case ECONNREFUSED:
+ case EHOSTUNREACH:
return 0; /* temporary */
default:
return 1; /* permanent */
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] mount: Mount should retry unreachable hosts
[not found] ` <20100310214136.3002.78499.stgit-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
@ 2010-03-19 20:15 ` Steve Dickson
0 siblings, 0 replies; 2+ messages in thread
From: Steve Dickson @ 2010-03-19 20:15 UTC (permalink / raw)
To: Chuck Lever; +Cc: linux-nfs
On 03/10/2010 04:42 PM, Chuck Lever wrote:
> Currently if a server is up but not responding (ie, it answers ARP
> requests, but not NFS or RPC requests), mount retries or backgrounds
> itself waiting for the server.
>
> If the server is not responding on the network at all, mount fails
> the mount request immediately.
>
> Users might find it more useful if mount retried in both cases.
>
> Note that this change means attempting to mount using a misspelled
> server name will "hang" for the retry amount. I suppose the error
> message isn't very helpful whether it fails immediately or waits
> a couple of minutes, though I imagine that an unreachable server is a
> much more common occurrence than a misspelling.
>
> Reported-by: Daniel Goering <g_daniel@gmx.net>
> Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
> ---
Committed...
steved.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-03-19 20:15 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-03-10 21:42 [PATCH] mount: Mount should retry unreachable hosts Chuck Lever
[not found] ` <20100310214136.3002.78499.stgit-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2010-03-19 20:15 ` Steve Dickson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox