* 2.6.36 access-bits bugfix
@ 2010-09-02 21:13 J. Bruce Fields
0 siblings, 0 replies; only message in thread
From: J. Bruce Fields @ 2010-09-02 21:13 UTC (permalink / raw)
To: linux-nfs
I intend to pass this along to Linus as a 2.6.36 bugfix.
This is one of several bugs that have been due to ignoring the existance
of higher bits in the access mask. I wonder what we could change to
eliminate the whole class of problems? Maybe store these bits into
separate fields right away in the xdr decoding?
--b.
commit 8f34a430ac16d5fbd9d6b383184d35e152f5a963
Author: J. Bruce Fields <bfields@redhat.com>
Date: Thu Sep 2 15:23:16 2010 -0400
nfsd4: mask out non-access bits in nfs4_access_to_omode
This fixes an unnecessary BUG().
Signed-off-by: J. Bruce Fields <bfields@redhat.com>
diff --git a/fs/nfsd/nfs4state.c b/fs/nfsd/nfs4state.c
index 3dfef06..cf0d2ff 100644
--- a/fs/nfsd/nfs4state.c
+++ b/fs/nfsd/nfs4state.c
@@ -440,7 +440,7 @@ test_share(struct nfs4_stateid *stp, struct nfsd4_open *open) {
static int nfs4_access_to_omode(u32 access)
{
- switch (access) {
+ switch (access & NFS4_SHARE_ACCESS_BOTH) {
case NFS4_SHARE_ACCESS_READ:
return O_RDONLY;
case NFS4_SHARE_ACCESS_WRITE:
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2010-09-02 21:13 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-09-02 21:13 2.6.36 access-bits bugfix J. Bruce Fields
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox