* bug in match_ipaddr6 ?
@ 2010-09-02 22:36 Ben Greear
2010-09-03 13:02 ` Jeff Layton
0 siblings, 1 reply; 2+ messages in thread
From: Ben Greear @ 2010-09-02 22:36 UTC (permalink / raw)
To: linux-nfs@vger.kernel.org
static int nfs_sockaddr_match_ipaddr6(const struct sockaddr *sa1,
const struct sockaddr *sa2)
{
const struct sockaddr_in6 *sin1 = (const struct sockaddr_in6 *)sa1;
const struct sockaddr_in6 *sin2 = (const struct sockaddr_in6 *)sa2;
if (ipv6_addr_scope(&sin1->sin6_addr) == IPV6_ADDR_SCOPE_LINKLOCAL &&
sin1->sin6_scope_id != sin2->sin6_scope_id)
return 0;
return ipv6_addr_equal(&sin1->sin6_addr, &sin1->sin6_addr);
Looks like this last line, second argument should be &sin2->sin6_addr ???
Thanks,
Ben
--
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc http://www.candelatech.com
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: bug in match_ipaddr6 ?
2010-09-02 22:36 bug in match_ipaddr6 ? Ben Greear
@ 2010-09-03 13:02 ` Jeff Layton
0 siblings, 0 replies; 2+ messages in thread
From: Jeff Layton @ 2010-09-03 13:02 UTC (permalink / raw)
To: Ben Greear; +Cc: linux-nfs@vger.kernel.org, chuck.lever
On Thu, 02 Sep 2010 15:36:39 -0700
Ben Greear <greearb@candelatech.com> wrote:
> static int nfs_sockaddr_match_ipaddr6(const struct sockaddr *sa1,
> const struct sockaddr *sa2)
> {
> const struct sockaddr_in6 *sin1 = (const struct sockaddr_in6 *)sa1;
> const struct sockaddr_in6 *sin2 = (const struct sockaddr_in6 *)sa2;
>
> if (ipv6_addr_scope(&sin1->sin6_addr) == IPV6_ADDR_SCOPE_LINKLOCAL &&
> sin1->sin6_scope_id != sin2->sin6_scope_id)
> return 0;
>
> return ipv6_addr_equal(&sin1->sin6_addr, &sin1->sin6_addr);
>
> Looks like this last line, second argument should be &sin2->sin6_addr ???
>
> Thanks,
> Ben
>
Ouch. Yes, that does look wrong. Care to send a patch to fix it?
--
Jeff Layton <jlayton@redhat.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-09-03 12:59 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-09-02 22:36 bug in match_ipaddr6 ? Ben Greear
2010-09-03 13:02 ` Jeff Layton
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox