Linux NFS development
 help / color / mirror / Atom feed
From: "J. Bruce Fields" <bfields@redhat.com>
To: Boaz Harrosh <bharrosh@panasas.com>
Cc: NFS list <linux-nfs@vger.kernel.org>
Subject: Re: Grace period NEVER ends
Date: Thu, 11 Aug 2011 22:15:57 -0400	[thread overview]
Message-ID: <20110812021556.GD9761@pad.fieldses.org> (raw)
In-Reply-To: <4E4481F0.2050806@panasas.com>

On Thu, Aug 11, 2011 at 06:29:20PM -0700, Boaz Harrosh wrote:
> With this patch I'm back to the previous behavior. That is
> wait your grace period then continue.

Is it true for some reason that the client never sends RECLAIM_COMPLETE?

--b.

> 
> ---
> NFSD: Remove a wrong check in nfs4_open
> 
> We are already doing the proper grace period checking
> farther down in nfs4_open. This check was just checking
> nothing and was totally unrelated to the comment about
> "RECLAIM_COMPLETE". It was a bug because if an open was
> coming before the grace period end, it would then never
> pass the condition of not being cl_firststate.
> 
> Boaz
> 
> ---
> @@ -295,15 +295,6 @@ nfsd4_open(struct svc_rqst *rqstp, struct nfsd4_compound_state *cstate,
>  	if (open->op_create && open->op_claim_type != NFS4_OPEN_CLAIM_NULL)
>  		return nfserr_inval;
>  
> -	/*
> -	 * RFC5661 18.51.3
> -	 * Before RECLAIM_COMPLETE done, server should deny new lock
> -	 */
> -	if (nfsd4_has_session(cstate) &&
> -	    !cstate->session->se_client->cl_firststate &&
> -	    open->op_claim_type != NFS4_OPEN_CLAIM_PREVIOUS)
> -		return nfserr_grace;
> -
>  	if (nfsd4_has_session(cstate))
>  		copy_clientid(&open->op_clientid, cstate->session);
>  
> 

  reply	other threads:[~2011-08-12  2:16 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-12  0:51 Grace period NEVER ends Boaz Harrosh
2011-08-12  1:14 ` J. Bruce Fields
2011-08-12  1:16 ` Boaz Harrosh
2011-08-12  1:29   ` Boaz Harrosh
2011-08-12  2:15     ` J. Bruce Fields [this message]
2011-08-12 14:08       ` Casey Bodley
2011-08-12 14:32         ` J. Bruce Fields
2011-08-12 18:06           ` Boaz Harrosh
2011-08-12 18:39             ` J. Bruce Fields
2011-08-12 19:00               ` Boaz Harrosh
2011-08-12 20:36                 ` J. Bruce Fields
2011-08-12 20:44                   ` Boaz Harrosh
2011-08-12 20:48                     ` J. Bruce Fields
2011-08-12 19:30           ` Casey Bodley
2011-08-12 20:36           ` Boaz Harrosh
2011-08-12 21:09             ` Boaz Harrosh
2011-08-12 15:52     ` Trond Myklebust
2011-08-12 16:25       ` J. Bruce Fields

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110812021556.GD9761@pad.fieldses.org \
    --to=bfields@redhat.com \
    --cc=bharrosh@panasas.com \
    --cc=linux-nfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox