From: "J. Bruce Fields" <bfields@redhat.com>
To: Casey Bodley <cbodley@citi.umich.edu>
Cc: Boaz Harrosh <bharrosh@panasas.com>,
NFS list <linux-nfs@vger.kernel.org>,
Mi Jinlong <mijinlong@cn.fujitsu.com>,
Malcolm Locke <malc@wholemeal.co.nz>
Subject: Re: Grace period NEVER ends
Date: Fri, 12 Aug 2011 10:32:29 -0400 [thread overview]
Message-ID: <20110812143228.GD16960@pad.fieldses.org> (raw)
In-Reply-To: <CAMeBU_28VPCtExvU1gr3oTbLLyqp=qFwFjxehoea64Xqi=_ncQ@mail.gmail.com>
On Fri, Aug 12, 2011 at 10:08:03AM -0400, Casey Bodley wrote:
> On Thu, Aug 11, 2011 at 10:15 PM, J. Bruce Fields <bfields@redhat.com> wrote:
> > On Thu, Aug 11, 2011 at 06:29:20PM -0700, Boaz Harrosh wrote:
> >> With this patch I'm back to the previous behavior. That is
> >> wait your grace period then continue.
> >
> > Is it true for some reason that the client never sends RECLAIM_COMPLETE?
>
> I tested this yesterday with the windows client and saw the same
> never-ending grace period on OPEN. We do send RECLAIM_COMPLETE, and
> it completes successfully. Other operations like CREATE and REMOVE
> succeed as well.
Argh. Does this help?
Unfortunately, this doesn't explain Malcolm Locke's problem, as it's 4.1
specific.
--b.
commit d43b4d070a24edcbe5f5e9ffcf7a33bbeccdd47d
Author: J. Bruce Fields <bfields@redhat.com>
Date: Fri Aug 12 10:27:18 2011 -0400
nfsd4: fix failure to end nfsd4 grace period
Even if we fail to write a recovery record to stable storage, we should
still mark the client as having acquired its first state. Otherwise we
leave 4.1 clients with indefinite ERR_GRACE returns.
Signed-off-by: J. Bruce Fields <bfields@redhat.com>
diff --git a/fs/nfsd/nfs4recover.c b/fs/nfsd/nfs4recover.c
index 29d77f6..4c7537d 100644
--- a/fs/nfsd/nfs4recover.c
+++ b/fs/nfsd/nfs4recover.c
@@ -156,10 +156,9 @@ out_put:
dput(dentry);
out_unlock:
mutex_unlock(&dir->d_inode->i_mutex);
- if (status == 0) {
- clp->cl_firststate = 1;
+ if (status == 0)
vfs_fsync(rec_file, 0);
- }
+ clp->cl_firststate = 1;
nfs4_reset_creds(original_cred);
dprintk("NFSD: nfsd4_create_clid_dir returns %d\n", status);
return status;
next prev parent reply other threads:[~2011-08-12 14:32 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-12 0:51 Grace period NEVER ends Boaz Harrosh
2011-08-12 1:14 ` J. Bruce Fields
2011-08-12 1:16 ` Boaz Harrosh
2011-08-12 1:29 ` Boaz Harrosh
2011-08-12 2:15 ` J. Bruce Fields
2011-08-12 14:08 ` Casey Bodley
2011-08-12 14:32 ` J. Bruce Fields [this message]
2011-08-12 18:06 ` Boaz Harrosh
2011-08-12 18:39 ` J. Bruce Fields
2011-08-12 19:00 ` Boaz Harrosh
2011-08-12 20:36 ` J. Bruce Fields
2011-08-12 20:44 ` Boaz Harrosh
2011-08-12 20:48 ` J. Bruce Fields
2011-08-12 19:30 ` Casey Bodley
2011-08-12 20:36 ` Boaz Harrosh
2011-08-12 21:09 ` Boaz Harrosh
2011-08-12 15:52 ` Trond Myklebust
2011-08-12 16:25 ` J. Bruce Fields
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110812143228.GD16960@pad.fieldses.org \
--to=bfields@redhat.com \
--cc=bharrosh@panasas.com \
--cc=cbodley@citi.umich.edu \
--cc=linux-nfs@vger.kernel.org \
--cc=malc@wholemeal.co.nz \
--cc=mijinlong@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox