From: "J. Bruce Fields" <bfields@fieldses.org>
To: Boaz Harrosh <bharrosh@panasas.com>
Cc: Benny Halevy <benny@tonian.com>,
NFS list <linux-nfs@vger.kernel.org>,
Steve Dickson <steved@redhat.com>
Subject: Re: Subject: [PATCH] SQUASHME: pnfsd: nfs4pnfsd.c should dprint under NFSDDBG_PNFS
Date: Mon, 14 Nov 2011 18:09:23 -0500 [thread overview]
Message-ID: <20111114230923.GA3718@fieldses.org> (raw)
In-Reply-To: <4EBBF605.9050403@panasas.com>
On Thu, Nov 10, 2011 at 08:04:21AM -0800, Boaz Harrosh wrote:
> On 11/09/2011 11:55 AM, J. Bruce Fields wrote:
> > Hey now, nfs4pnfsd.c has enough problems of its own without being
> > accused of surliness.
> >
>
> Allow me to disagree! the nfs4pnfsd.c is a very nice pretty clean,
> well formatted and well implemented pNFS-Server implementation.
> Believe me I have seen a few other pNFS and Parallel servers
> implementation and this is surgery room clean compare to the other.
> (If you look at the point before pnfs-exp and spNFS patches)
OK, I hope so! And we *are* getting closer to finishing off the last of
the 4.1 stuff (though with just me it's not going to happen for 3.3.),
so I hope to be looking at that soon.
> The only real mess in there is the mess already inherited from nfsd,
> like the great and grate messy locking.
You mean the overuse of the state lock, or something else?
--b.
> Though it's better then the rest of the NFSD code.
next prev parent reply other threads:[~2011-11-14 23:09 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-09 3:51 Subject: [PATCH] SQUASHME: pnfsd: nfs4pnfsd.c should dprint under NFSDDBG_PNFS Boaz Harrosh
2011-11-09 19:55 ` J. Bruce Fields
2011-11-10 6:55 ` Benny Halevy
2011-11-10 16:04 ` Boaz Harrosh
2011-11-10 16:09 ` Boaz Harrosh
2011-11-14 23:09 ` J. Bruce Fields [this message]
2011-11-14 23:35 ` Boaz Harrosh
2011-11-14 23:53 ` J. Bruce Fields
2011-11-10 6:55 ` Benny Halevy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111114230923.GA3718@fieldses.org \
--to=bfields@fieldses.org \
--cc=benny@tonian.com \
--cc=bharrosh@panasas.com \
--cc=linux-nfs@vger.kernel.org \
--cc=steved@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox