From: Benny Halevy <bhalevy@tonian.com>
To: "J. Bruce Fields" <bfields@fieldses.org>
Cc: Boaz Harrosh <bharrosh@panasas.com>,
NFS list <linux-nfs@vger.kernel.org>,
Steve Dickson <steved@redhat.com>
Subject: Re: Subject: [PATCH] SQUASHME: pnfsd: nfs4pnfsd.c should dprint under NFSDDBG_PNFS
Date: Thu, 10 Nov 2011 08:55:59 +0200 [thread overview]
Message-ID: <4EBB757F.7080509@tonian.com> (raw)
In-Reply-To: <20111109195510.GA2227@fieldses.org>
On 2011-11-09 21:55, J. Bruce Fields wrote:
> On Tue, Nov 08, 2011 at 07:51:50PM -0800, Boaz Harrosh wrote:
>>
>> I've been squinting at pnfsd dprints for ages and aching under the wait. So I headed
>> up to the nfsd/debug.h to add a PNFS channel, and what do you know? there is one!
>> It's used by nfs4pnfsds.c. Surly nfs4pnfsd.c is more _PNFS than _PROC.
>
> Hey now, nfs4pnfsd.c has enough problems of its own without being
> accused of surliness.
:-)
>
> --b.
>
>>
>> While at it I changed nfs4pnfsdlm.c to, also already defined, NFSDDBG_FILELAYOUT
>> which was unused before this patch.
>>
>> CC: Steve Dickson <steved@redhat.com>
>> Signed-off-by: Boaz Harrosh <bharrosh@panasas.com>
>> ---
>> fs/nfsd/nfs4pnfsd.c | 2 +-
>> fs/nfsd/nfs4pnfsdlm.c | 2 +-
>> 2 files changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/fs/nfsd/nfs4pnfsd.c b/fs/nfsd/nfs4pnfsd.c
>> index 18b8fca..f514ebe 100644
>> --- a/fs/nfsd/nfs4pnfsd.c
>> +++ b/fs/nfsd/nfs4pnfsd.c
>> @@ -23,7 +23,7 @@
>>
>> #include "pnfsd.h"
>>
>> -#define NFSDDBG_FACILITY NFSDDBG_PROC
>> +#define NFSDDBG_FACILITY NFSDDBG_PNFS
>>
>> /* Globals */
>> static u32 current_layoutid = 1;
>> diff --git a/fs/nfsd/nfs4pnfsdlm.c b/fs/nfsd/nfs4pnfsdlm.c
>> index abc4d83..0f0441a 100644
>> --- a/fs/nfsd/nfs4pnfsdlm.c
>> +++ b/fs/nfsd/nfs4pnfsdlm.c
>> @@ -30,7 +30,7 @@
>> #include "nfsfh.h"
>> #include "nfsd.h"
>>
>> -#define NFSDDBG_FACILITY NFSDDBG_PROC
>> +#define NFSDDBG_FACILITY NFSDDBG_FILELAYOUT
>>
>> /* Just use a linked list. Do not expect more than 32 dlm_device_entries
>> * the first implementation will just use one device per cluster file system
>> --
>> 1.7.6.2
>>
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at http://vger.kernel.org/majordomo-info.html
> --
> To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2011-11-10 6:56 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-09 3:51 Subject: [PATCH] SQUASHME: pnfsd: nfs4pnfsd.c should dprint under NFSDDBG_PNFS Boaz Harrosh
2011-11-09 19:55 ` J. Bruce Fields
2011-11-10 6:55 ` Benny Halevy [this message]
2011-11-10 16:04 ` Boaz Harrosh
2011-11-10 16:09 ` Boaz Harrosh
2011-11-14 23:09 ` J. Bruce Fields
2011-11-14 23:35 ` Boaz Harrosh
2011-11-14 23:53 ` J. Bruce Fields
2011-11-10 6:55 ` Benny Halevy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EBB757F.7080509@tonian.com \
--to=bhalevy@tonian.com \
--cc=bfields@fieldses.org \
--cc=bharrosh@panasas.com \
--cc=linux-nfs@vger.kernel.org \
--cc=steved@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox