From: "J. Bruce Fields" <bfields@fieldses.org>
To: Jeff Layton <jlayton@redhat.com>
Cc: bfields@fieldses.net, sandeen@redhat.com, linux-nfs@vger.kernel.org
Subject: Re: [PATCH] nfsd: trivial: use SEEK_SET instead of 0 in vfs_llseek
Date: Wed, 25 Apr 2012 18:18:09 -0400 [thread overview]
Message-ID: <20120425221809.GC3251@fieldses.org> (raw)
In-Reply-To: <1335382088-5463-1-git-send-email-jlayton@redhat.com>
On Wed, Apr 25, 2012 at 03:28:08PM -0400, Jeff Layton wrote:
> They're equivalent, but SEEK_SET is more informative...
Applied, thanks.--b.
>
> Cc: Eric Sandeen <sandeen@redhat.com>
> Signed-off-by: Jeff Layton <jlayton@redhat.com>
> ---
> fs/nfsd/vfs.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/fs/nfsd/vfs.c b/fs/nfsd/vfs.c
> index 5686661..c8bd9c3 100644
> --- a/fs/nfsd/vfs.c
> +++ b/fs/nfsd/vfs.c
> @@ -2039,7 +2039,7 @@ nfsd_readdir(struct svc_rqst *rqstp, struct svc_fh *fhp, loff_t *offsetp,
> if (err)
> goto out;
>
> - offset = vfs_llseek(file, offset, 0);
> + offset = vfs_llseek(file, offset, SEEK_SET);
> if (offset < 0) {
> err = nfserrno((int)offset);
> goto out_close;
> --
> 1.7.7.6
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2012-04-25 22:18 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-25 19:28 [PATCH] nfsd: trivial: use SEEK_SET instead of 0 in vfs_llseek Jeff Layton
2012-04-25 22:18 ` J. Bruce Fields [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120425221809.GC3251@fieldses.org \
--to=bfields@fieldses.org \
--cc=bfields@fieldses.net \
--cc=jlayton@redhat.com \
--cc=linux-nfs@vger.kernel.org \
--cc=sandeen@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox