* [PATCH] nfsd: trivial: use SEEK_SET instead of 0 in vfs_llseek
@ 2012-04-25 19:28 Jeff Layton
2012-04-25 22:18 ` J. Bruce Fields
0 siblings, 1 reply; 2+ messages in thread
From: Jeff Layton @ 2012-04-25 19:28 UTC (permalink / raw)
To: bfields; +Cc: sandeen, linux-nfs
They're equivalent, but SEEK_SET is more informative...
Cc: Eric Sandeen <sandeen@redhat.com>
Signed-off-by: Jeff Layton <jlayton@redhat.com>
---
fs/nfsd/vfs.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/fs/nfsd/vfs.c b/fs/nfsd/vfs.c
index 5686661..c8bd9c3 100644
--- a/fs/nfsd/vfs.c
+++ b/fs/nfsd/vfs.c
@@ -2039,7 +2039,7 @@ nfsd_readdir(struct svc_rqst *rqstp, struct svc_fh *fhp, loff_t *offsetp,
if (err)
goto out;
- offset = vfs_llseek(file, offset, 0);
+ offset = vfs_llseek(file, offset, SEEK_SET);
if (offset < 0) {
err = nfserrno((int)offset);
goto out_close;
--
1.7.7.6
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] nfsd: trivial: use SEEK_SET instead of 0 in vfs_llseek
2012-04-25 19:28 [PATCH] nfsd: trivial: use SEEK_SET instead of 0 in vfs_llseek Jeff Layton
@ 2012-04-25 22:18 ` J. Bruce Fields
0 siblings, 0 replies; 2+ messages in thread
From: J. Bruce Fields @ 2012-04-25 22:18 UTC (permalink / raw)
To: Jeff Layton; +Cc: bfields, sandeen, linux-nfs
On Wed, Apr 25, 2012 at 03:28:08PM -0400, Jeff Layton wrote:
> They're equivalent, but SEEK_SET is more informative...
Applied, thanks.--b.
>
> Cc: Eric Sandeen <sandeen@redhat.com>
> Signed-off-by: Jeff Layton <jlayton@redhat.com>
> ---
> fs/nfsd/vfs.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/fs/nfsd/vfs.c b/fs/nfsd/vfs.c
> index 5686661..c8bd9c3 100644
> --- a/fs/nfsd/vfs.c
> +++ b/fs/nfsd/vfs.c
> @@ -2039,7 +2039,7 @@ nfsd_readdir(struct svc_rqst *rqstp, struct svc_fh *fhp, loff_t *offsetp,
> if (err)
> goto out;
>
> - offset = vfs_llseek(file, offset, 0);
> + offset = vfs_llseek(file, offset, SEEK_SET);
> if (offset < 0) {
> err = nfserrno((int)offset);
> goto out_close;
> --
> 1.7.7.6
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-04-25 22:18 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-04-25 19:28 [PATCH] nfsd: trivial: use SEEK_SET instead of 0 in vfs_llseek Jeff Layton
2012-04-25 22:18 ` J. Bruce Fields
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox