From: Andi Kleen <ak@linux.intel.com>
To: "Myklebust, Trond" <Trond.Myklebust@netapp.com>
Cc: Fengguang Wu <fengguang.wu@intel.com>,
Linux-NFS <linux-nfs@vger.kernel.org>
Subject: Re: rpcauth_lookup_credcache() lock contentions
Date: Sun, 24 Jun 2012 19:45:52 -0700 [thread overview]
Message-ID: <20120625024552.GJ4152@tassilo.jf.intel.com> (raw)
In-Reply-To: <1340587274.8758.11.camel@lade.trondhjem.org>
> I believe that the spinlock is there in order to ensure that the
> test_bit() and get_rpccred() are atomic w.r.t. garbage collection.
Normally RCU should ensure that already with minor care.
Only drop after a quiescent period and when the reference is still 0.
And drop always when the refcount goes to 0.
-Andi
--
ak@linux.intel.com -- Speaking for myself only
next prev parent reply other threads:[~2012-06-25 2:45 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20120623122604.GA10887@localhost>
2012-06-23 15:07 ` rpcauth_lookup_credcache() lock contentions Fengguang Wu
2012-06-24 21:34 ` Andi Kleen
2012-06-25 1:21 ` Myklebust, Trond
2012-06-25 2:45 ` Andi Kleen [this message]
2012-06-25 2:42 ` Fengguang Wu
2012-06-27 18:03 ` Andi Kleen
2012-06-27 18:36 ` Myklebust, Trond
2012-07-05 13:11 ` Fengguang Wu
2012-07-05 15:05 ` Malahal Naineni
2012-07-05 16:29 ` Andi Kleen
2012-07-05 16:27 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120625024552.GJ4152@tassilo.jf.intel.com \
--to=ak@linux.intel.com \
--cc=Trond.Myklebust@netapp.com \
--cc=fengguang.wu@intel.com \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox