From: Andi Kleen <ak@linux.intel.com>
To: Fengguang Wu <fengguang.wu@intel.com>
Cc: Linux-NFS <linux-nfs@vger.kernel.org>, Trond.Myklebust@netapp.com
Subject: Re: rpcauth_lookup_credcache() lock contentions
Date: Thu, 5 Jul 2012 09:27:20 -0700 [thread overview]
Message-ID: <20120705162720.GE32640@tassilo.jf.intel.com> (raw)
In-Reply-To: <20120705131105.GA13775@localhost>
On Thu, Jul 05, 2012 at 09:11:05PM +0800, Fengguang Wu wrote:
> On Wed, Jun 27, 2012 at 11:03:53AM -0700, Andi Kleen wrote:
> > > > Can you try this patch?
> > >
> > > Thank you! This patch brings %sys down to 24%, a pretty large improvement!
> >
> > I redid the patch now and fixed the race Trond pointed out.
> >
> > Fengguang, can you retest please? Trond, does it look good now?
>
> Andi, this patch performs equally well! And it runs stable for over a week.
Thanks for testing. But it still has the race Trond pointed out.
Probably need to rely on write ordering with the uncached flag.
-Andi
prev parent reply other threads:[~2012-07-05 16:27 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20120623122604.GA10887@localhost>
2012-06-23 15:07 ` rpcauth_lookup_credcache() lock contentions Fengguang Wu
2012-06-24 21:34 ` Andi Kleen
2012-06-25 1:21 ` Myklebust, Trond
2012-06-25 2:45 ` Andi Kleen
2012-06-25 2:42 ` Fengguang Wu
2012-06-27 18:03 ` Andi Kleen
2012-06-27 18:36 ` Myklebust, Trond
2012-07-05 13:11 ` Fengguang Wu
2012-07-05 15:05 ` Malahal Naineni
2012-07-05 16:29 ` Andi Kleen
2012-07-05 16:27 ` Andi Kleen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120705162720.GE32640@tassilo.jf.intel.com \
--to=ak@linux.intel.com \
--cc=Trond.Myklebust@netapp.com \
--cc=fengguang.wu@intel.com \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox