Linux NFS development
 help / color / mirror / Atom feed
* [nfs:testing 6/19] fs/nfs/callback.c:239:3: error: 'ret' undeclared
@ 2012-10-16 17:24 Fengguang Wu
  2012-10-16 17:27 ` Myklebust, Trond
  0 siblings, 1 reply; 2+ messages in thread
From: Fengguang Wu @ 2012-10-16 17:24 UTC (permalink / raw)
  To: Trond Myklebust; +Cc: kernel-janitors, linux-nfs

Hi Trond,

FYI, kernel build failed on

tree:   git://git.linux-nfs.org/projects/trondmy/linux-nfs.git testing
head:   7d84fbe58c098cb9200e1d9180ae50d49e54e4e2
commit: 8c47a6a6ce14a7baf1c5d6a169523cb083f9aaa9 [6/19] NFSv4: Remove an unused variable from nfs_callback_start_svc
config: x86_64-allyesconfig # make ARCH=x86_64 

All error/warnings:

fs/nfs/callback.c: In function 'nfs_callback_start_svc':
fs/nfs/callback.c:239:3: error: 'ret' undeclared (first use in this function)
fs/nfs/callback.c:239:3: note: each undeclared identifier is reported only once for each function it appears in

vim +239 fs/nfs/callback.c

8e246144 Stanislav Kinsbursky 2012-08-20  233  
8e246144 Stanislav Kinsbursky 2012-08-20  234  	sprintf(svc_name, "nfsv4.%u-svc", minorversion);
8e246144 Stanislav Kinsbursky 2012-08-20  235  	cb_info->serv = serv;
8e246144 Stanislav Kinsbursky 2012-08-20  236  	cb_info->rqst = rqstp;
8e246144 Stanislav Kinsbursky 2012-08-20  237  	cb_info->task = kthread_run(callback_svc, cb_info->rqst, svc_name);
8e246144 Stanislav Kinsbursky 2012-08-20  238  	if (IS_ERR(cb_info->task)) {
8e246144 Stanislav Kinsbursky 2012-08-20 @239  		ret = PTR_ERR(cb_info->task);
8e246144 Stanislav Kinsbursky 2012-08-20  240  		svc_exit_thread(cb_info->rqst);
8e246144 Stanislav Kinsbursky 2012-08-20  241  		cb_info->rqst = NULL;
8e246144 Stanislav Kinsbursky 2012-08-20  242  		cb_info->task = NULL;

The code at line 239 was first introduced by commit:
8e24614 NFS: callback service start function introduced


---
0-DAY kernel build testing backend         Open Source Technology Center
Fengguang Wu, Yuanhan Liu                              Intel Corporation

^ permalink raw reply	[flat|nested] 2+ messages in thread

* RE: [nfs:testing 6/19] fs/nfs/callback.c:239:3: error: 'ret' undeclared
  2012-10-16 17:24 [nfs:testing 6/19] fs/nfs/callback.c:239:3: error: 'ret' undeclared Fengguang Wu
@ 2012-10-16 17:27 ` Myklebust, Trond
  0 siblings, 0 replies; 2+ messages in thread
From: Myklebust, Trond @ 2012-10-16 17:27 UTC (permalink / raw)
  To: Fengguang Wu; +Cc: kernel-janitors@vger.kernel.org, linux-nfs@vger.kernel.org

> -----Original Message-----
> From: Fengguang Wu [mailto:fengguang.wu@intel.com]
> Sent: Tuesday, October 16, 2012 1:24 PM
> To: Myklebust, Trond
> Cc: kernel-janitors@vger.kernel.org; linux-nfs@vger.kernel.org
> Subject: [nfs:testing 6/19] fs/nfs/callback.c:239:3: error: 'ret' undeclared
> 
> Hi Trond,
> 
> FYI, kernel build failed on
> 
> tree:   git://git.linux-nfs.org/projects/trondmy/linux-nfs.git testing
> head:   7d84fbe58c098cb9200e1d9180ae50d49e54e4e2
> commit: 8c47a6a6ce14a7baf1c5d6a169523cb083f9aaa9 [6/19] NFSv4: Remove
> an unused variable from nfs_callback_start_svc
> config: x86_64-allyesconfig # make ARCH=x86_64
> 
> All error/warnings:
> 
> fs/nfs/callback.c: In function 'nfs_callback_start_svc':
> fs/nfs/callback.c:239:3: error: 'ret' undeclared (first use in this function)
> fs/nfs/callback.c:239:3: note: each undeclared identifier is reported only once
> for each function it appears in
> 

Hi Fengguang,

Yes. This issue is already fixed in the repository. Sorry for having pushed it out too quickly...

Cheers
  Trond

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2012-10-16 17:27 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-10-16 17:24 [nfs:testing 6/19] fs/nfs/callback.c:239:3: error: 'ret' undeclared Fengguang Wu
2012-10-16 17:27 ` Myklebust, Trond

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox