Linux NFS development
 help / color / mirror / Atom feed
From: "J. Bruce Fields" <bfields@fieldses.org>
To: Srikrishan Malik <srimalik@in.ibm.com>
Cc: linux-nfs@vger.kernel.org, nfs-ganesha-devel@lists.sourceforge.net
Subject: Re: [PATCH] Use original reserved port setting for reconnect.
Date: Fri, 11 Jul 2014 15:24:17 -0400	[thread overview]
Message-ID: <20140711192417.GH9775@fieldses.org> (raw)
In-Reply-To: <1405007526-2234-1-git-send-email-srimalik@in.ibm.com>

Thanks, applying.--b.

On Thu, Jul 10, 2014 at 09:22:06PM +0530, Srikrishan Malik wrote:
> Signed-off-by: Srikrishan Malik <srimalik@in.ibm.com>
> ---
> Reconnect ignores the "--secure" arg after connection reset.                  
> If the export is secure then OPs after reconnect fail with NFS4ERR_ACCESS.
>  nfs4.0/lib/rpc/rpc.py |    3 ++-
>  1 files changed, 2 insertions(+), 1 deletions(-)
> 
> diff --git a/nfs4.0/lib/rpc/rpc.py b/nfs4.0/lib/rpc/rpc.py
> index 8b39df4..5ef2e3e 100644
> --- a/nfs4.0/lib/rpc/rpc.py
> +++ b/nfs4.0/lib/rpc/rpc.py
> @@ -305,7 +305,8 @@ class RPCClient(object):
>          self.lock.acquire()
>          self._socket[t].close()
>          out = self._socket[t] = socket.socket(self.af, socket.SOCK_STREAM)
> -        # out.bind
> +        if self.uselowport:
> +            self.bindsocket(out)
>          out.connect((self.remotehost, self.remoteport))
>          out.settimeout(self.timeout)
>          self.lock.release()
> -- 
> 1.7.1
> 

      reply	other threads:[~2014-07-11 19:24 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-10 15:52 [PATCH] Use original reserved port setting for reconnect Srikrishan Malik
2014-07-11 19:24 ` J. Bruce Fields [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140711192417.GH9775@fieldses.org \
    --to=bfields@fieldses.org \
    --cc=linux-nfs@vger.kernel.org \
    --cc=nfs-ganesha-devel@lists.sourceforge.net \
    --cc=srimalik@in.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox