Linux NFS development
 help / color / mirror / Atom feed
* [PATCH] Use original reserved port setting for reconnect.
@ 2014-07-10 15:52 Srikrishan Malik
  2014-07-11 19:24 ` J. Bruce Fields
  0 siblings, 1 reply; 2+ messages in thread
From: Srikrishan Malik @ 2014-07-10 15:52 UTC (permalink / raw)
  To: bfields; +Cc: linux-nfs, Srikrishan Malik

Signed-off-by: Srikrishan Malik <srimalik@in.ibm.com>
---
Reconnect ignores the "--secure" arg after connection reset.                  
If the export is secure then OPs after reconnect fail with NFS4ERR_ACCESS.
 nfs4.0/lib/rpc/rpc.py |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/nfs4.0/lib/rpc/rpc.py b/nfs4.0/lib/rpc/rpc.py
index 8b39df4..5ef2e3e 100644
--- a/nfs4.0/lib/rpc/rpc.py
+++ b/nfs4.0/lib/rpc/rpc.py
@@ -305,7 +305,8 @@ class RPCClient(object):
         self.lock.acquire()
         self._socket[t].close()
         out = self._socket[t] = socket.socket(self.af, socket.SOCK_STREAM)
-        # out.bind
+        if self.uselowport:
+            self.bindsocket(out)
         out.connect((self.remotehost, self.remoteport))
         out.settimeout(self.timeout)
         self.lock.release()
-- 
1.7.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] Use original reserved port setting for reconnect.
  2014-07-10 15:52 [PATCH] Use original reserved port setting for reconnect Srikrishan Malik
@ 2014-07-11 19:24 ` J. Bruce Fields
  0 siblings, 0 replies; 2+ messages in thread
From: J. Bruce Fields @ 2014-07-11 19:24 UTC (permalink / raw)
  To: Srikrishan Malik; +Cc: linux-nfs, nfs-ganesha-devel

Thanks, applying.--b.

On Thu, Jul 10, 2014 at 09:22:06PM +0530, Srikrishan Malik wrote:
> Signed-off-by: Srikrishan Malik <srimalik@in.ibm.com>
> ---
> Reconnect ignores the "--secure" arg after connection reset.                  
> If the export is secure then OPs after reconnect fail with NFS4ERR_ACCESS.
>  nfs4.0/lib/rpc/rpc.py |    3 ++-
>  1 files changed, 2 insertions(+), 1 deletions(-)
> 
> diff --git a/nfs4.0/lib/rpc/rpc.py b/nfs4.0/lib/rpc/rpc.py
> index 8b39df4..5ef2e3e 100644
> --- a/nfs4.0/lib/rpc/rpc.py
> +++ b/nfs4.0/lib/rpc/rpc.py
> @@ -305,7 +305,8 @@ class RPCClient(object):
>          self.lock.acquire()
>          self._socket[t].close()
>          out = self._socket[t] = socket.socket(self.af, socket.SOCK_STREAM)
> -        # out.bind
> +        if self.uselowport:
> +            self.bindsocket(out)
>          out.connect((self.remotehost, self.remoteport))
>          out.settimeout(self.timeout)
>          self.lock.release()
> -- 
> 1.7.1
> 

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2014-07-11 19:24 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-07-10 15:52 [PATCH] Use original reserved port setting for reconnect Srikrishan Malik
2014-07-11 19:24 ` J. Bruce Fields

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox