Linux NFS development
 help / color / mirror / Atom feed
From: "J. Bruce Fields" <bfields@fieldses.org>
To: Jeff Layton <jeff.layton@primarydata.com>
Cc: Christoph Hellwig <hch@infradead.org>, linux-nfs@vger.kernel.org
Subject: Re: [PATCH 00/11] nfsd: deny mode handling overhaul
Date: Mon, 14 Jul 2014 09:38:10 -0400	[thread overview]
Message-ID: <20140714133810.GC17956@fieldses.org> (raw)
In-Reply-To: <20140713075250.18677c29@tlielax.poochiereds.net>

On Sun, Jul 13, 2014 at 07:52:50AM -0400, Jeff Layton wrote:
> On Sun, 13 Jul 2014 04:42:44 -0700
> Christoph Hellwig <hch@infradead.org> wrote:
> 
> > On Fri, Jul 11, 2014 at 11:42:27AM -0400, Jeff Layton wrote:
> > > Yes, thanks to both of you. The review and merging are much
> > > appreciated. Only 89 patches to go once these go in!
> > 
> > Might help if we can get them into slighly smaller reviewable chunks,
> > e.g. the next batch might be the stateid refcounting and everything
> > around it, deferring the various client and session related bits and the
> > fault injection changes for now.
> 
> That should be doable as long as we're ok with adding in superfluous
> spinlocking until the client_mutex is removed.

It means that an attempt to bisect any race introduced by the series
will land on the one patch that drops the state lock.

But maybe that's the best we can do.

--b.

> I'll work on breaking
> out the next set. It might be a few days as I'm still looking at
> whether it's feasible to not alter the sc_type like the code does today.

  reply	other threads:[~2014-07-14 13:38 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-10 18:07 [PATCH 00/11] nfsd: deny mode handling overhaul Jeff Layton
2014-07-10 18:07 ` [PATCH 01/11] nfsd: Add fine grained protection for the nfs4_file->fi_stateids list Jeff Layton
2014-07-10 18:07 ` [PATCH 02/11] nfsd: Add locking to the nfs4_file->fi_fds[] array Jeff Layton
2014-07-10 18:07 ` [PATCH 03/11] nfsd: clean up helper __release_lock_stateid Jeff Layton
2014-07-10 18:07 ` [PATCH 04/11] nfsd: refactor nfs4_file_get_access and nfs4_file_put_access Jeff Layton
2014-07-10 18:07 ` [PATCH 05/11] nfsd: remove nfs4_file_put_fd Jeff Layton
2014-07-10 18:07 ` [PATCH 06/11] nfsd: shrink st_access_bmap and st_deny_bmap Jeff Layton
2014-07-10 18:07 ` [PATCH 07/11] nfsd: set stateid access and deny bits in nfs4_get_vfs_file Jeff Layton
2014-07-10 18:07 ` [PATCH 08/11] nfsd: clean up reset_union_bmap_deny Jeff Layton
2014-07-10 18:07 ` [PATCH 09/11] nfsd: always hold the fi_lock when bumping fi_access refcounts Jeff Layton
2014-07-10 18:07 ` [PATCH 10/11] nfsd: make deny mode enforcement more efficient and close races in it Jeff Layton
2014-07-10 20:08   ` J. Bruce Fields
2014-07-11 17:31   ` Frank Filz
2014-07-11 17:48     ` Jeff Layton
2014-07-11 17:56       ` Frank Filz
2014-07-11 18:00         ` Trond Myklebust
2014-07-11 18:07           ` Jeff Layton
2014-07-11 18:08           ` Frank Filz
2014-07-10 18:07 ` [PATCH 11/11] nfsd: cleanup and rename nfs4_check_open Jeff Layton
2014-07-10 20:14 ` [PATCH 00/11] nfsd: deny mode handling overhaul J. Bruce Fields
2014-07-11  7:46   ` Christoph Hellwig
2014-07-11 14:31     ` J. Bruce Fields
2014-07-11 15:42       ` Jeff Layton
2014-07-13 11:42         ` Christoph Hellwig
2014-07-13 11:52           ` Jeff Layton
2014-07-14 13:38             ` J. Bruce Fields [this message]
2014-07-15 10:00               ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140714133810.GC17956@fieldses.org \
    --to=bfields@fieldses.org \
    --cc=hch@infradead.org \
    --cc=jeff.layton@primarydata.com \
    --cc=linux-nfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox