From: Chuck Lever <chuck.lever@oracle.com>
To: linux-rdma@vger.kernel.org, linux-nfs@vger.kernel.org
Subject: [PATCH v3 14/21] xprtrdma: Disable completions for FAST_REG_MR Work Requests
Date: Tue, 15 Jul 2014 10:22:12 -0400 [thread overview]
Message-ID: <20140715142212.8908.73331.stgit@manet.1015granger.net> (raw)
In-Reply-To: <20140715142020.8908.80969.stgit@manet.1015granger.net>
Instead of relying on a completion to change the state of an FRMR
to FRMR_IS_VALID, set it in advance. If an error occurs, a completion
will fire anyway and mark the FRMR FRMR_IS_STALE.
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
Tested-by: Steve Wise <swise@opengridcomputing.com>
---
net/sunrpc/xprtrdma/verbs.c | 9 ++++-----
1 file changed, 4 insertions(+), 5 deletions(-)
diff --git a/net/sunrpc/xprtrdma/verbs.c b/net/sunrpc/xprtrdma/verbs.c
index 8429869..b36a5dd 100644
--- a/net/sunrpc/xprtrdma/verbs.c
+++ b/net/sunrpc/xprtrdma/verbs.c
@@ -159,10 +159,7 @@ rpcrdma_sendcq_process_wc(struct ib_wc *wc)
return;
}
- if (wc->opcode == IB_WC_FAST_REG_MR)
- frmr->r.frmr.fr_state = FRMR_IS_VALID;
- else if (wc->opcode == IB_WC_LOCAL_INV)
- frmr->r.frmr.fr_state = FRMR_IS_INVALID;
+ frmr->r.frmr.fr_state = FRMR_IS_INVALID;
}
static int
@@ -1724,10 +1721,11 @@ rpcrdma_register_frmr_external(struct rpcrdma_mr_seg *seg,
dprintk("RPC: %s: Using frmr %p to map %d segments\n",
__func__, mw, i);
+ frmr->fr_state = FRMR_IS_VALID;
+
memset(&frmr_wr, 0, sizeof frmr_wr);
frmr_wr.wr_id = (unsigned long)(void *)mw;
frmr_wr.opcode = IB_WR_FAST_REG_MR;
- frmr_wr.send_flags = IB_SEND_SIGNALED;
frmr_wr.wr.fast_reg.iova_start = seg1->mr_dma;
frmr_wr.wr.fast_reg.page_list = frmr->fr_pgl;
frmr_wr.wr.fast_reg.page_list_len = page_no;
@@ -1761,6 +1759,7 @@ rpcrdma_register_frmr_external(struct rpcrdma_mr_seg *seg,
*nsegs = i;
return 0;
out_err:
+ frmr->fr_state = FRMR_IS_INVALID;
while (i--)
rpcrdma_unmap_one(ia, --seg);
return rc;
next prev parent reply other threads:[~2014-07-15 14:22 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-15 14:20 [PATCH v3 01/21] xprtrdma: Fix panic in rpcrdma_register_frmr_external() Chuck Lever
2014-07-15 14:20 ` [PATCH v3 02/21] xprtrdma: Protect ia->ri_id when unmapping/invalidating MRs Chuck Lever
2014-07-15 14:20 ` [PATCH v3 03/21] xprtrdma: Limit data payload size for ALLPHYSICAL Chuck Lever
2014-07-15 14:20 ` [PATCH v3 04/21] xprtrdma: Update rkeys after transport reconnect Chuck Lever
2014-07-15 14:20 ` [PATCH v3 05/21] xprtrdma: On disconnect, don't ignore pending CQEs Chuck Lever
2014-07-15 14:21 ` [PATCH v3 06/21] xprtrdma: Don't invalidate FRMRs if registration fails Chuck Lever
2014-07-15 14:21 ` [PATCH v3 07/21] xprtrdma: Unclutter struct rpcrdma_mr_seg Chuck Lever
2014-07-15 14:21 ` [PATCH v3 08/21] xprtrdma: Back off rkey when FAST_REG_MR fails Chuck Lever
2014-07-15 14:21 ` [PATCH v3 09/21] xprtrdma: Chain together all MWs in same buffer pool Chuck Lever
2014-07-15 14:21 ` [PATCH v3 10/21] xprtrdma: Properly handle exhaustion of the rb_mws list Chuck Lever
2014-07-15 14:21 ` [PATCH v3 11/21] xprtrdma: Reset FRMRs when FAST_REG_MR is flushed by a disconnect Chuck Lever
2014-07-15 14:21 ` [PATCH v3 12/21] xprtrdma: Reset FRMRs after a flushed LOCAL_INV Work Request Chuck Lever
2014-07-15 14:22 ` [PATCH v3 13/21] xprtrdma: Don't post a LOCAL_INV in rpcrdma_register_frmr_external() Chuck Lever
2014-07-15 14:22 ` Chuck Lever [this message]
2014-07-15 14:22 ` [PATCH v3 15/21] xprtrdma: Disable completions for LOCAL_INV Work Requests Chuck Lever
2014-07-15 14:22 ` [PATCH v3 16/21] xprtrdma: Rename frmr_wr Chuck Lever
2014-07-15 14:22 ` [PATCH v3 17/21] xprtrdma: Allocate each struct rpcrdma_mw separately Chuck Lever
2014-07-15 14:22 ` [PATCH v3 18/21] xprtrdma: Schedule reply tasklet once per upcall Chuck Lever
2014-07-15 14:22 ` [PATCH v3 19/21] xprtrdma: Make rpcrdma_ep_disconnect() return void Chuck Lever
2014-07-15 14:23 ` [PATCH v3 20/21] xprtrdma: Remove RPCRDMA_PERSISTENT_REGISTRATION macro Chuck Lever
2014-07-15 14:23 ` [PATCH v3 21/21] xprtrdma: Handle additional connection events Chuck Lever
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140715142212.8908.73331.stgit@manet.1015granger.net \
--to=chuck.lever@oracle.com \
--cc=linux-nfs@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox