Linux NFS development
 help / color / mirror / Atom feed
From: Chuck Lever <chuck.lever@oracle.com>
To: linux-rdma@vger.kernel.org, linux-nfs@vger.kernel.org
Subject: [PATCH v3 21/21] xprtrdma: Handle additional connection events
Date: Tue, 15 Jul 2014 10:23:12 -0400	[thread overview]
Message-ID: <20140715142311.8908.23658.stgit@manet.1015granger.net> (raw)
In-Reply-To: <20140715142020.8908.80969.stgit@manet.1015granger.net>

Commit 38ca83a5 added RDMA_CM_EVENT_TIMEWAIT_EXIT. But that status
is relevant only for consumers that re-use their QPs on new
connections. xprtrdma creates a fresh QP on reconnection, so that
event should be explicitly ignored.

Squelch the alarming "unexpected CM event" message.

Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
Tested-by: Steve Wise <swise@opengridcomputing.com>
---
 net/sunrpc/xprtrdma/verbs.c |   25 ++++++++++++++-----------
 1 file changed, 14 insertions(+), 11 deletions(-)

diff --git a/net/sunrpc/xprtrdma/verbs.c b/net/sunrpc/xprtrdma/verbs.c
index 721a6fd..6ead5df 100644
--- a/net/sunrpc/xprtrdma/verbs.c
+++ b/net/sunrpc/xprtrdma/verbs.c
@@ -326,8 +326,16 @@ static const char * const conn[] = {
 	"rejected",
 	"established",
 	"disconnected",
-	"device removal"
+	"device removal",
+	"multicast join",
+	"multicast error",
+	"address change",
+	"timewait exit",
 };
+
+#define CONNECTION_MSG(status)						\
+	((status) < ARRAY_SIZE(conn) ?					\
+		conn[(status)] : "unrecognized connection error")
 #endif
 
 static int
@@ -385,23 +393,18 @@ rpcrdma_conn_upcall(struct rdma_cm_id *id, struct rdma_cm_event *event)
 	case RDMA_CM_EVENT_DEVICE_REMOVAL:
 		connstate = -ENODEV;
 connected:
-		dprintk("RPC:       %s: %s: %pI4:%u (ep 0x%p event 0x%x)\n",
-			__func__,
-			(event->event <= 11) ? conn[event->event] :
-						"unknown connection error",
-			&addr->sin_addr.s_addr,
-			ntohs(addr->sin_port),
-			ep, event->event);
 		atomic_set(&rpcx_to_rdmax(ep->rep_xprt)->rx_buf.rb_credits, 1);
 		dprintk("RPC:       %s: %sconnected\n",
 					__func__, connstate > 0 ? "" : "dis");
 		ep->rep_connected = connstate;
 		ep->rep_func(ep);
 		wake_up_all(&ep->rep_connect_wait);
-		break;
+		/*FALLTHROUGH*/
 	default:
-		dprintk("RPC:       %s: unexpected CM event %d\n",
-			__func__, event->event);
+		dprintk("RPC:       %s: %pI4:%u (ep 0x%p): %s\n",
+			__func__, &addr->sin_addr.s_addr,
+			ntohs(addr->sin_port), ep,
+			CONNECTION_MSG(event->event));
 		break;
 	}
 


      parent reply	other threads:[~2014-07-15 14:23 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-15 14:20 [PATCH v3 01/21] xprtrdma: Fix panic in rpcrdma_register_frmr_external() Chuck Lever
2014-07-15 14:20 ` [PATCH v3 02/21] xprtrdma: Protect ia->ri_id when unmapping/invalidating MRs Chuck Lever
2014-07-15 14:20 ` [PATCH v3 03/21] xprtrdma: Limit data payload size for ALLPHYSICAL Chuck Lever
2014-07-15 14:20 ` [PATCH v3 04/21] xprtrdma: Update rkeys after transport reconnect Chuck Lever
2014-07-15 14:20 ` [PATCH v3 05/21] xprtrdma: On disconnect, don't ignore pending CQEs Chuck Lever
2014-07-15 14:21 ` [PATCH v3 06/21] xprtrdma: Don't invalidate FRMRs if registration fails Chuck Lever
2014-07-15 14:21 ` [PATCH v3 07/21] xprtrdma: Unclutter struct rpcrdma_mr_seg Chuck Lever
2014-07-15 14:21 ` [PATCH v3 08/21] xprtrdma: Back off rkey when FAST_REG_MR fails Chuck Lever
2014-07-15 14:21 ` [PATCH v3 09/21] xprtrdma: Chain together all MWs in same buffer pool Chuck Lever
2014-07-15 14:21 ` [PATCH v3 10/21] xprtrdma: Properly handle exhaustion of the rb_mws list Chuck Lever
2014-07-15 14:21 ` [PATCH v3 11/21] xprtrdma: Reset FRMRs when FAST_REG_MR is flushed by a disconnect Chuck Lever
2014-07-15 14:21 ` [PATCH v3 12/21] xprtrdma: Reset FRMRs after a flushed LOCAL_INV Work Request Chuck Lever
2014-07-15 14:22 ` [PATCH v3 13/21] xprtrdma: Don't post a LOCAL_INV in rpcrdma_register_frmr_external() Chuck Lever
2014-07-15 14:22 ` [PATCH v3 14/21] xprtrdma: Disable completions for FAST_REG_MR Work Requests Chuck Lever
2014-07-15 14:22 ` [PATCH v3 15/21] xprtrdma: Disable completions for LOCAL_INV " Chuck Lever
2014-07-15 14:22 ` [PATCH v3 16/21] xprtrdma: Rename frmr_wr Chuck Lever
2014-07-15 14:22 ` [PATCH v3 17/21] xprtrdma: Allocate each struct rpcrdma_mw separately Chuck Lever
2014-07-15 14:22 ` [PATCH v3 18/21] xprtrdma: Schedule reply tasklet once per upcall Chuck Lever
2014-07-15 14:22 ` [PATCH v3 19/21] xprtrdma: Make rpcrdma_ep_disconnect() return void Chuck Lever
2014-07-15 14:23 ` [PATCH v3 20/21] xprtrdma: Remove RPCRDMA_PERSISTENT_REGISTRATION macro Chuck Lever
2014-07-15 14:23 ` Chuck Lever [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140715142311.8908.23658.stgit@manet.1015granger.net \
    --to=chuck.lever@oracle.com \
    --cc=linux-nfs@vger.kernel.org \
    --cc=linux-rdma@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox