Linux NFS development
 help / color / mirror / Atom feed
* VFS regression: commit aba809cf0944 breaks MNT_SHRINKABLE automounted partitions
@ 2014-08-29 16:27 Trond Myklebust
  2014-08-29 20:58 ` Al Viro
  0 siblings, 1 reply; 10+ messages in thread
From: Trond Myklebust @ 2014-08-29 16:27 UTC (permalink / raw)
  To: Alexander Viro; +Cc: Devel FS Linux, Linux NFS Mailing List, Tao Peng

Hi Al,

Our internal testing shows that commit aba809cf0944 (namespace.c: get
rid of mnt_ghosts) appears to break the NFS automounter functionality.
When unmounting, the user now gets a permanent -EBUSY, presumably due
to a refcounting issue with the patch.

The reproducer is as follows:

On the server, set up an export of the form:

% showmount -e 192.168.214.128
Export list for 192.168.214.128:
/export *

On the client:

[fedora19@~]$sudo mount 192.168.214.128:/ /mnt/
[fedora19@~]$df
Filesystem               Size  Used Avail Use% Mounted on
/dev/mapper/fedora-root   38G   15G   24G  38% /
devtmpfs                 229M     0  229M   0% /dev
tmpfs                    242M   80K  242M   1% /dev/shm
tmpfs                    242M  1.5M  241M   1% /run
tmpfs                    242M     0  242M   0% /sys/fs/cgroup
tmpfs                    242M  4.0K  242M   1% /tmp
/dev/sda1                1.5G  248M  1.3G  17% /boot
192.168.214.128:/         28G   25G  1.1G  96% /mnt
[fedora19@~]$ls /mnt/export/
[fedora19@~]$df
Filesystem               Size  Used Avail Use% Mounted on
/dev/mapper/fedora-root   38G   15G   24G  38% /
devtmpfs                 229M     0  229M   0% /dev
tmpfs                    242M   80K  242M   1% /dev/shm
tmpfs                    242M  1.5M  241M   1% /run
tmpfs                    242M     0  242M   0% /sys/fs/cgroup
tmpfs                    242M  4.0K  242M   1% /tmp
/dev/sda1                1.5G  248M  1.3G  17% /boot
192.168.214.128:/         28G   25G  1.1G  96% /mnt
192.168.214.128:/export   28G   25G  1.1G  96% /mnt/export
[fedora19@~]$sudo umount /mnt
umount.nfs4: /mnt: device is busy
[fedora19@~]$df
Filesystem               Size  Used Avail Use% Mounted on
/dev/mapper/fedora-root   38G   15G   24G  38% /
devtmpfs                 229M     0  229M   0% /dev
tmpfs                    242M   80K  242M   1% /dev/shm
tmpfs                    242M  1.5M  241M   1% /run
tmpfs                    242M     0  242M   0% /sys/fs/cgroup
tmpfs                    242M  4.0K  242M   1% /tmp
/dev/sda1                1.5G  248M  1.3G  17% /boot
192.168.214.128:/         28G   25G  1.1G  96% /mnt

Reverting commit aba809cf0944 fixes the problem for us on a 3.14.15
client kernel.
(Thanks to Tao Peng for providing the above reproducer and for bisecting.)

Cheers
  Trond
-- 
Trond Myklebust

Linux NFS client maintainer, PrimaryData

trond.myklebust@primarydata.com

^ permalink raw reply	[flat|nested] 10+ messages in thread

end of thread, other threads:[~2014-09-01 23:52 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-08-29 16:27 VFS regression: commit aba809cf0944 breaks MNT_SHRINKABLE automounted partitions Trond Myklebust
2014-08-29 20:58 ` Al Viro
2014-08-29 21:47   ` Trond Myklebust
2014-08-29 23:01     ` Al Viro
2014-08-30  0:38       ` Peng Tao
2014-08-30 17:36         ` Al Viro
2014-08-30 23:27           ` Al Viro
2014-08-31  0:31             ` Peng Tao
2014-08-31  4:09               ` Al Viro
2014-09-01 23:52                 ` Dave Chinner

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox