Incorrect backport to 2.6.32-stable - NFSD regression.

Incorrect backport to 2.6.32-stable - NFSD regression.

[NeilBrown]

[-- Attachment #1: Type: text/plain, Size: 1025 bytes --]


2.6.32.30 contains:

commit 63d059e73ff4574b79bd8aa252b5fc00b6326ddf
Author: NeilBrown <neilb@suse.de>
Date:   Wed Feb 16 13:08:35 2011 +1100

    nfsd: correctly handle return value from nfsd_map_name_to_*
    
    commit 47c85291d3dd1a51501555000b90f8e281a0458e upstream.
    
    These functions return an nfs status, not a host_err.  So don't
    try to convert  before returning.
    
    This is a regression introduced by
    3c726023402a2f3b28f49b9d90ebf9e71151157d; I fixed up two of the callers,
    but missed these two.
    
    Reported-by: Herbert Poetzl <herbert@13thfloor.at>
    Signed-off-by: NeilBrown <neilb@suse.de>
    Signed-off-by: J. Bruce Fields <bfields@redhat.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>


But it does *not* contain a backport of
3c726023402a2f3b28f49b9d90ebf9e71151157d.

So rather an fixing a regression, it introduces one.

This patch should be reverted.

See also https://bugzilla.novell.com/show_bug.cgi?id=893787

NeilBrown

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 828 bytes --]

Re: Incorrect backport to 2.6.32-stable - NFSD regression.

[Luis Henriques]

(Adding Willy to the CC list, in case he misses this email.)

On Wed, Sep 03, 2014 at 11:28:43AM +1000, NeilBrown wrote:
> 
> 2.6.32.30 contains:
> 
> commit 63d059e73ff4574b79bd8aa252b5fc00b6326ddf
> Author: NeilBrown <neilb@suse.de>
> Date:   Wed Feb 16 13:08:35 2011 +1100
> 
>     nfsd: correctly handle return value from nfsd_map_name_to_*
>     
>     commit 47c85291d3dd1a51501555000b90f8e281a0458e upstream.
>     
>     These functions return an nfs status, not a host_err.  So don't
>     try to convert  before returning.
>     
>     This is a regression introduced by
>     3c726023402a2f3b28f49b9d90ebf9e71151157d; I fixed up two of the callers,
>     but missed these two.
>     
>     Reported-by: Herbert Poetzl <herbert@13thfloor.at>
>     Signed-off-by: NeilBrown <neilb@suse.de>
>     Signed-off-by: J. Bruce Fields <bfields@redhat.com>
>     Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
> 
> 
> But it does *not* contain a backport of
> 3c726023402a2f3b28f49b9d90ebf9e71151157d.
> 
> So rather an fixing a regression, it introduces one.
> 
> This patch should be reverted.
> 
> See also https://bugzilla.novell.com/show_bug.cgi?id=893787
> 
> NeilBrown

Thanks a lot for reporting this here, Neil.  I'll make sure we revert
it from the Ubuntu 10.04 LTS kernel.

Cheers,
--
Luís

Re: Incorrect backport to 2.6.32-stable - NFSD regression.

[Willy Tarreau]

Hi guys,

On Fri, Sep 05, 2014 at 10:21:05AM +0100, Luis Henriques wrote:
> (Adding Willy to the CC list, in case he misses this email.)

Thank you Luis, I indeed missed it!

> On Wed, Sep 03, 2014 at 11:28:43AM +1000, NeilBrown wrote:
> > 
> > 2.6.32.30 contains:
> > 
> > commit 63d059e73ff4574b79bd8aa252b5fc00b6326ddf
> > Author: NeilBrown <neilb@suse.de>
> > Date:   Wed Feb 16 13:08:35 2011 +1100
> > 
> >     nfsd: correctly handle return value from nfsd_map_name_to_*
> >     
> >     commit 47c85291d3dd1a51501555000b90f8e281a0458e upstream.
> >     
> >     These functions return an nfs status, not a host_err.  So don't
> >     try to convert  before returning.
> >     
> >     This is a regression introduced by
> >     3c726023402a2f3b28f49b9d90ebf9e71151157d; I fixed up two of the callers,
> >     but missed these two.
> >     
> >     Reported-by: Herbert Poetzl <herbert@13thfloor.at>
> >     Signed-off-by: NeilBrown <neilb@suse.de>
> >     Signed-off-by: J. Bruce Fields <bfields@redhat.com>
> >     Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
> > 
> > 
> > But it does *not* contain a backport of
> > 3c726023402a2f3b28f49b9d90ebf9e71151157d.
> > 
> > So rather an fixing a regression, it introduces one.
> > 
> > This patch should be reverted.

Thanks Neil, I'm queuing this request for next version. I'm slowly
catching up from my move and hope to be able to deliver it "soon".

Best regards,
willy