* [PATCH] NFS: Fabricate fscache server index key correctly
@ 2014-09-25 13:34 David Howells
0 siblings, 0 replies; only message in thread
From: David Howells @ 2014-09-25 13:34 UTC (permalink / raw)
To: trond.myklebust
Cc: linux-nfs, Steve Dickson, linux-kernel, dhowells, linux-cachefs,
james-p
When fabricating a server index key for fscache, we should clear the index key
buffer before starting to fill it in, not in the middle.
Reported-by: James Pearson <james-p@moving-picture.com>
Signed-off-by: David Howells <dhowells@redhat.com>
Acked-by: Steve Dickson <steved@redhat.com>
---
fs/nfs/fscache-index.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/fs/nfs/fscache-index.c b/fs/nfs/fscache-index.c
index 7cf2c4699b08..777b055063f6 100644
--- a/fs/nfs/fscache-index.c
+++ b/fs/nfs/fscache-index.c
@@ -74,11 +74,10 @@ static uint16_t nfs_server_get_key(const void *cookie_netfs_data,
struct nfs_server_key *key = buffer;
uint16_t len = sizeof(struct nfs_server_key);
+ memset(key, 0, len);
key->nfsversion = clp->rpc_ops->version;
key->family = clp->cl_addr.ss_family;
- memset(key, 0, len);
-
switch (clp->cl_addr.ss_family) {
case AF_INET:
key->port = sin->sin_port;
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2014-09-25 13:35 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-09-25 13:34 [PATCH] NFS: Fabricate fscache server index key correctly David Howells
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox