From: Christoph Hellwig <hch@infradead.org>
To: Trond Myklebust <trond.myklebust@primarydata.com>
Cc: linux-nfs@vger.kernel.org, Weston Andros Adamson <dros@primarydata.com>
Subject: Re: [PATCH] NFSv4.1/pnfs: replace broken pnfs_put_lseg_async
Date: Thu, 9 Oct 2014 09:02:14 -0700 [thread overview]
Message-ID: <20141009160214.GA32766@infradead.org> (raw)
In-Reply-To: <1412801200-17936-1-git-send-email-trond.myklebust@primarydata.com>
On Wed, Oct 08, 2014 at 04:46:40PM -0400, Trond Myklebust wrote:
> You cannot call pnfs_put_lseg_async() more than once per lseg, so it
> is really an inappropriate way to deal with a refcount issue.
>
> Instead, replace it with a function that decrements the refcount, and
> puts the final 'free' operation (which is incompatible with locks) on
> the workqueue.
How about calling the clear_request_commit layout driver operation
from a workqueue? That seems like a much saner approach.
next prev parent reply other threads:[~2014-10-09 16:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-08 20:46 [PATCH] NFSv4.1/pnfs: replace broken pnfs_put_lseg_async Trond Myklebust
2014-10-09 2:11 ` Weston Andros Adamson
2014-10-09 16:02 ` Christoph Hellwig [this message]
2014-10-09 18:36 ` Trond Myklebust
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141009160214.GA32766@infradead.org \
--to=hch@infradead.org \
--cc=dros@primarydata.com \
--cc=linux-nfs@vger.kernel.org \
--cc=trond.myklebust@primarydata.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox