From: Christoph Hellwig <hch@lst.de>
To: Trond Myklebust <trond.myklebust@primarydata.com>
Cc: Weston Andros Adamson <dros@primarydata.com>,
Peng Tao <bergwolf@primarydata.com>,
linux-nfs list <linux-nfs@vger.kernel.org>
Subject: Re: [PATCH] NFS: fix subtle change in COMMIT behavior
Date: Tue, 25 Nov 2014 14:06:46 +0100 [thread overview]
Message-ID: <20141125130646.GA30673@lst.de> (raw)
In-Reply-To: <1416866672.3523.1.camel@leira.trondhjem.org>
On Mon, Nov 24, 2014 at 05:04:32PM -0500, Trond Myklebust wrote:
> On Fri, 2014-11-14 at 08:04 +0100, Christoph Hellwig wrote:
> > The patch below passes block layout testing for me:
>
> Hmm... Are you sure? It didn't compile for me, due to the misspelled
> 'nrpages'.
Hmm, my locally commited version has nrpages, while the one on the list has
nr_pages. The one I tested obviously had nrpages.
prev parent reply other threads:[~2014-11-25 13:06 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-12 17:08 [PATCH] NFS: fix subtle change in COMMIT behavior Weston Andros Adamson
2014-11-13 1:03 ` Peng Tao
2014-11-13 11:02 ` Christoph Hellwig
2014-11-13 13:38 ` Weston Andros Adamson
2014-11-13 13:38 ` Christoph Hellwig
2014-11-14 7:04 ` Christoph Hellwig
2014-11-14 15:02 ` Weston Andros Adamson
2014-11-24 22:04 ` Trond Myklebust
2014-11-24 23:47 ` Tom Haynes
2014-11-25 13:06 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141125130646.GA30673@lst.de \
--to=hch@lst.de \
--cc=bergwolf@primarydata.com \
--cc=dros@primarydata.com \
--cc=linux-nfs@vger.kernel.org \
--cc=trond.myklebust@primarydata.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox